Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2.1k
    • Issues 2.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 149
    • Merge requests 149
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !2378

extensionSystem: Check if mode is supported when loading

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Alessandro Bono requested to merge abono/gnome-shell:wip/abono/extension-unlock-dialog-mode-only into main Jul 14, 2022
  • Overview 5
  • Commits 1
  • Pipelines 12
  • Changes 1

Don't try to initialize and then enable an extension if it is not supported in the current mode. Otherwise the extension will not be initialized, and the initial ERROR state is not cleared. Once it is in ERROR state we can't enable it anymore when we switch mode. Instead, leave the extension in INITIALIZED state, so that it will be initialized when appropriate. This happens for extensions that support the unlock-dialog mode but not the user mode.

Edited Jul 19, 2022 by Alessandro Bono
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/abono/extension-unlock-dialog-mode-only