Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,835
    • Issues 1,835
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 133
    • Merge requests 133
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !2303

layout: Add a property to tell whether we're running on a smartphone

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Jonas Dreßler requested to merge verdre/gnome-shell:is-phone-property into main May 24, 2022
  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 1

We're going to adjust a few things in the shell UI to allow running gnome-shell on smartphones. To do this, it will be necessary to detect whether we're running on a phone, so add a property to layoutManager that tells us.

Note that the heuristics to detect phones here is obviously quite subjective and a bit tricky, right now it's simply checking whether the primary monitor size is smaller than 500x1000, which works fairly well and excludes smaller tablets. Given that the whole web seems to rely only on checking the screen size in pixels, this seems to be not as bad as one might think.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: is-phone-property