Skip to content

Rounded corners for workspace previews

Daniel van Vugt requested to merge vanvugt/gnome-shell:fix-issue-4096 into main

Using layoutManager.stateAdjustment would treat ControlsState.HIDDEN the same as ControlsState.APP_GRID:

ControlsState stateAdjustment Rounded corners
HIDDEN:0 0.0 No
WINDOW_PICKER:1 1.0 Yes
APP_GRID:2 0.0 No (issue #4096)

and so rounded corners were accidentally lost for ControlsState.APP_GRID (issue #4096).

But it's not as simple as treating ControlsState.APP_GRID the same as ControlsState.WINDOW_PICKER because that would break allocate which only needs its downscaling algorithm enabled for ControlsState.WINDOW_PICKER (because ControlsState.APP_GRID is already downscaled by the parent allocation).

So we now map those two problems separately:

ControlsState Rounded corners Downscale from parent
HIDDEN:0 No No
WINDOW_PICKER:1 Yes Yes
APP_GRID:2 Yes No

Fixes: #4096

Requires: !2143 (merged)

Before:
before

After:
after

Edited by Daniel van Vugt

Merge request reports