Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,835
    • Issues 1,835
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 133
    • Merge requests 133
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !2068

workspaceAnimation: Make WorkspaceGroup class public

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rastersoft requested to merge rastersoft/gnome-shell:make_WorkspaceGroup_public into main Dec 18, 2021
  • Overview 4
  • Commits 1
  • Pipelines 6
  • Changes 1

The WorkspaceGroup class in defined as CONST, which means that, strictly speaking, is inaccessible from outside the file workspaceAnimation.js. But Desktop Icons NG needs access to it.

Although the current Javascript engine "tolerates" this access, a warning message is shown in the log advertising that it's incorrect, and that although it is still allowed, the code should be fixed.

This patch changes the definition from CONST to VAR to allow accessing it from extensions.

Edited Dec 22, 2021 by Rastersoft
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: make_WorkspaceGroup_public