Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2.1k
    • Issues 2.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 147
    • Merge requests 147
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !2012

Use libadwaita for extension preferences

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Florian Müllner requested to merge fmuellner/gnome-shell:adw-prefs into main Oct 29, 2021
  • Overview 21
  • Commits 8
  • Pipelines 28
  • Changes 7

This is the counter-part of !1997 (merged): When we adopt libadwaita for the extensions app, the actual dialogs should use libadwaita as well to make sure we use a consistent stylesheet (and dark-mode support).

This also replaces !1868 (closed) by providing official access to the dialog to extension authors.

The former bit should be uncontroversial, the latter could use some discussion:

  • I'm not too enthusiastic about the fillPrefsWindow name

  • AdwPreferencesWindow provides a standardized and convenient way for preference dialogs (good), but also limits what extensions can do (may be controversial)

Fixes #4248 (closed)

Edited Oct 30, 2021 by Florian Müllner
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: adw-prefs