Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,857
    • Issues 1,857
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 135
    • Merge requests 135
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !1889

[Backport to 40] windowManager: Remove timeout on starting X11 services

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Olivier Fourdan requested to merge ofourdan/gnome-shell:backport-40-remove-x11-services-timeout into gnome-40 Jun 16, 2021
  • Overview 1
  • Commits 1
  • Pipelines 4
  • Changes 1

With Xwayland started on demand, mutter/gnome-shell will spawn Xwayland and GNOME settings daemon Xsettings.

Currently, gnome-shell uses a timeout of 5 seconds before canceling the launch and declare failure to start X11 services.

While 5 seconds may seem like a lot of time, when this is executed on a virtual machine part of a QA tests under load, this causes random failures.

There is no good value here, we could increase the timeout but it will always remain racy. Instead, remove the timeout, systemd itself already has a timeout mechanism (with a much longer wait time).

Thanks to Benjamin Berg bberg@redhat.com for finding the root cause and suggesting the fix.

Part-of: !1888 (merged) (cherry picked from commit 8be5d336)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: backport-40-remove-x11-services-timeout