Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,857
    • Issues 1,857
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 135
    • Merge requests 135
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !1819

dialog: Fix unexpected argument in action callback

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Florian Müllner requested to merge fmuellner/gnome-shell:close-callback into master Apr 19, 2021
  • Overview 0
  • Commits 3
  • Pipelines 4
  • Changes 2

This fixes the same issue as commit c5b18ee6, but for the audio device selection dialog.

And to avoid the same issue coming back to bite us in other dialogs, it makes sure the callback is always called without arguments, which is what callers expect.

Fixes #4139 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: close-callback