Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2.1k
    • Issues 2.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 147
    • Merge requests 147
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !1817

dnd: Don't try to restore to parent location if parent got destroyed

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Sebastian Keller requested to merge skeller/gnome-shell:fix-dnd-cancel-after-parent-destroy into master Apr 17, 2021
  • Overview 0
  • Commits 1
  • Pipelines 4
  • Changes 1

The original parent of a dragged actor might have been destroyed after the drag has been started. When the drag is canceled and _dragOrigParent is set, the code is trying to get the current position and size of it when restoring. With a destroyed parent this however would result in a crash.

This could happen for example when starting a drag on a window preview while the overview is hiding and then releasing it once the transition is done.

Fixes #4024 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-dnd-cancel-after-parent-destroy