Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,857
    • Issues 1,857
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 135
    • Merge requests 135
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !1793

main: Use session mode property for welcome dialog

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Florian Müllner requested to merge fmuellner/gnome-shell:welcome-check into master Apr 05, 2021
  • Overview 0
  • Commits 1
  • Pipelines 4
  • Changes 2

We only want to show the welcome dialog in the user session, not on the login screen or during initial setup. We currently achieve that by explicitly checking for those mode names, but there are other modes like gnome-classic where the dialog is equally un- helpful. Support those cases by adding a session mode property that determines whether the welcome dialog should be enabled, so that modes can opt in or out of the feature themselves.

(Both the 'gdm' and 'initial-setup' modes are based on the 'restricted' mode, so this change does not affect them)

Fixes #4026 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: welcome-check