Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2.1k
    • Issues 2.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 151
    • Merge requests 151
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !1673

blur-effect: Don't use stage view when drawing off-stage

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jonas Dreßler requested to merge verdre/gnome-shell:fix-blur-crash into master Feb 13, 2021
  • Overview 7
  • Commits 1
  • Pipelines 8
  • Changes 1

When we're painting off-stage, for example because we're screencasting or taking a screenshot, there won't be a stage-view associated with the paint context. The BlurEffect previously didn't handle that case and would crash.

Fix that and handle that case by assuming the scale is 1 and not offsetting the rectangle we blit from the draw framebuffer.

Fixes #3301 (closed)

Edited Feb 15, 2021 by Robert Mader
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-blur-crash