Skip to content

[3.36] unlockDialog: Defend against absence of blur effect

Simon McVittie requested to merge wip/smcv/issue3071-3.36 into gnome-3-36

From: Zephaniah E. Loss-Cutler-Hull

widget.get_effect(...) can return null while locking the screen, resulting in a TypeError. In this situation the screen ends up black with a cursor but never going to sleep, and moving the mouse brings the old screen contents up but does not allow unlocking.

unlockDialog.js assumes that widget.get_effect will return non-null, but other places such as getWindowDimmer in windowManager.js go out of their way to be more careful.

[smcv: Add commit message, remove hard tabs]

Resolves: #3071 (closed)
Bug-Debian: https://bugs.debian.org/968440

See also !1412 (merged), for master.

Edited by Simon McVittie

Merge request reports