Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2.1k
    • Issues 2.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 149
    • Merge requests 149
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !1223

st: Ensure to reset all widget theme nodes

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Carlos Garnacho requested to merge wip/carlosg/invalidate-styles into master Apr 28, 2020
  • Overview 10
  • Commits 1
  • Pipelines 12
  • Changes 1

Theme node invalidation stops at unmapped widgets, and widgets that forget to chain up to the default ::style-changed implementation. This may leave stale nodes that were invalidated on StThemeContext::changed, but are still set on widgets, and maybe used for CSS property lookups.

Make it sure that theme node invalidation happens always by moving propagation outside the vfunc, and ensure the theme nodes are reset across the full actor tree. Emission of ::style-changed, and obtaining a new theme node may be delayed till when the actor is mapped.

The theme node is also cleared after unparenting an actor to avoid stale references.

This ensures that all widgets get their theme node cleared after stylesheet changes, instead of maybe being left with a theme node that's been cleared of all its properties.

Fixes: #2541 (closed)

Edited Apr 28, 2020 by Carlos Garnacho
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/carlosg/invalidate-styles