Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
gnome-shell
gnome-shell
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,301
    • Issues 1,301
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 108
    • Merge Requests 108
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • gnome-shellgnome-shell
  • Merge Requests
  • !1134

Merged
Opened Mar 27, 2020 by Florian Müllner@fmuellnerMaintainer

js: Add missing chain-ups in vfuncs

  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 7

Commit 55b57421 changed signal handlers to the corresponding vfuncs, but didn't always chain up as necessary. In most places this doesn't matter, but at the very least the commit broke activating message list items via the keyboard.

Add all (hopefully) the missing chain-ups to get the expected behavior back.

Fixes #2319 (closed)

Edited Mar 27, 2020 by Florian Müllner
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: GNOME/gnome-shell!1134
Source branch: chain-up