Merge request 2590 + commit 20a81d78 broke VRR
Bug summary
Merge request !2590 (merged) breaks VRR
when using tray icons. But as it also breaks tray icons on its own, it is only reproducible after commit 20a81d78 which fixes it.
Steps to reproduce
Trying to build gnome-shell
at 3716deaa (commit at which !2590 (merged) got merged) gives compilation errors, to reproduce we need to build at a few commits later 656efd33 when those errors got fixed. To sum up: checkout at 656efd33 and then cherry-pick 20a81d78.
- Build
gnome-shell
using informations above - Install and enable this three line extension : https://github.com/jp7677/hide-tray-icons
- Open a wine/proton game and observe that it uses the
FLIP
model /VRR
is enabled[1], then close it. - Execute a program using legacy tray icons (e.g. wine tray icons)[2].
- Open the same game again, observe that it now uses the
BLIT
model /VRR
is broken.
[1]: I'm enabling the Graphics API Visual Indicator
in NVIDIA settings to easily check it, I don't know how AMD users are checking it but looking at: https://github.com/ubuntu/gnome-shell-extension-appindicator/issues/441 they are also affected by the bug.
[2]: Seems like reproducing is also possible with programs using regular tray icons, not just legacy ones.
What happened
The FLIP
model broke, also breaking VRR
.
What did you expect to happen
Not breaking the FLIP
model.