Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
G
gnome-shell
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,261
    • Issues 1,261
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 104
    • Merge Requests 104
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • gnome-shell
  • Issues
  • #3544

Closed
Open
Opened Dec 29, 2020 by Sam Thursfield@sthursfieldDeveloper

Show results from search providers which have `NoDisplay=true`

I created a custom search provider, to integrate the online service Pinboard.in in my Shell overview. I did this by installing a .desktop file named uk.me.afuera.PinboardSearchProvider, and a corresponding D-Bus .service and .search-provider.ini file, and it works nicely.

However, this results in a useless "Pinboard.in" application appearing in the list of applications. It's harmless (executing it just starts the D-Bus service) but confusing. I would like a way to cause this to not appear in the applications list.

The XDG .desktop spec provides the NoDisplay option, but that causes the search provider to stop working (due to https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/master/js/ui/remoteSearch.js#L93).

I propose that NoDisplay shouldn't be considered for search providers. The spec says this:

NoDisplay means "this application exists, but don't display it in the menus". This can be useful to e.g. associate this application with MIME types, so that it gets launched from a file manager (or other apps), without having a menu entry for it (there are tons of good reasons for this, including e.g. the netscape -remote, or kfmclient openURL kind of stuff).

This is different to Hidden:

... It's strictly equivalent to the .desktop file not existing at all, as far as that user is concerned. ...

We should change https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/master/js/ui/remoteSearch.js#L93 to check only the 'hidden' attribute.

Edited Dec 29, 2020 by Sam Thursfield
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: GNOME/gnome-shell#3544