1. 22 May, 2020 2 commits
  2. 21 May, 2020 9 commits
    • verdre's avatar
      Use pid_t for meta_window_get_pid() · b88ed3f2
      verdre authored
      The return value of meta_window_get_pid() changed again and it now
      returns pid_t, which usually just resolves to int on most platforms. We
      should still use pid_t now though, so do that.
      
      !1188
      b88ed3f2
    • Andy Holmes's avatar
      StClipboard: add st_clipboard_get_mimetypes · 669b0f19
      Andy Holmes authored
      Since the `MetaSelection` of the global `StClipboard` is private (and
      should be), there is no reasonable way for extensions or external code
      to query the supported mime-types.
      
      Add `st_clipboard_get_mimetypes()` so this can be queried without
      poking around in private code.
      
      closes #2819
      669b0f19
    • Florian Müllner's avatar
      extensions-app: Indicate extension errors · 9cad7ae9
      Florian Müllner authored
      Currently there is no indication that an extension had an error except
      for the sensitivity of the switch (which may have a different cause).
      
      This is useful information to users, so add a small error indicator
      alongside the updates icon and show the actual error in the details.
      
      #2337
      9cad7ae9
    • Florian Müllner's avatar
      extensionSystem: Don't log error name · 48e6a582
      Florian Müllner authored
      logExtensionError() currently saves the error message by calling
      toString() on the passed error. That's convenient as it allows to
      pass a string instead of a "proper" error, but the result isn't
      great for the common Error case: Its toString() method prefixes
      the message with the error name, which usually is just "Error:".
      
      The plain message is more suitable for displaying it to users,
      so use that for Error objects.
      
      #2337
      48e6a582
    • Florian Müllner's avatar
      extensions-app: Reset switch handle when it becomes insensitive · d2583aa4
      Florian Müllner authored
      Currently the switches handle position reflects the requested
      extension state (as in: the user (de)activated the switch),
      while the actual extension state is reflected by the underlying
      state.
      
      That doesn't work well when the switch is insensitive though (for
      example on error), because the desaturation neuters the color
      that reflects the state.
      
      Address this by resetting the switch handle to the state when
      making it insensitive.
      
      !1263
      d2583aa4
    • Florian Müllner's avatar
      st: Remove BoxLayout child meta · 0ab34fe2
      Florian Müllner authored
      They were deprecated last cycle in favor of ClutterActor's own
      expand/align properties, time to retire them for good.
      
      !1274
      0ab34fe2
    • verdre's avatar
      st/theme: Remove entry from files_by_stylesheet after emitting signal · 0f947d4f
      verdre authored
      Since e06109c2 we keep old theme nodes
      valid during the emission of the "custom-stylesheets-changed" signal.
      
      It turns out that we might still look up the file of a stylesheet using
      the files_by_stylesheet hashtable during the emission of that signal,
      causing a crash because the assertion in _st_theme_resolve_url() fails.
      
      So fix that and remove the stylesheet entry from the files_by_stylesheet
      hashtable after emitting the "custom-stylesheets-changed" signal. And to
      be consistent, also remove the entry from the stylesheets_by_file
      hashtable after emitting the signal.
      
      Fixes: #2757
      0f947d4f
    • Andy Holmes's avatar
      StBoxLayout: Fix up some documentation · 9dc42187
      Andy Holmes authored
      `StBoxLayout` has a couple properties (`vertical` and `pack-start`)
      improperly referenced as signals, and is somewhat unclear these
      properties are wrappers around the underlying `ClutterBoxLayout`
      properties.
      
      Fix these up and add references to the underlying properties, rather
      than redescribing them.
      
      #2816
      9dc42187
    • Florian Müllner's avatar
      st: Remove deprecated Bin properties · 9c3c9a15
      Florian Müllner authored
      Those were deprecated last cycle in favor of ClutterActor's own
      expand/align properties, and don't have any effect anymore.
      
      Time to remove them for good.
      
      !1273
      9c3c9a15
  3. 20 May, 2020 2 commits
  4. 19 May, 2020 5 commits
  5. 18 May, 2020 4 commits
    • Florian Müllner's avatar
      extensionSystem: Prevent broken updates · 6ddd43f3
      Florian Müllner authored
      Spidermonkey caches imports, which means that uninstalling an
      old extension version and installing a new one doesn't work as
      expected: If the previous version was loaded, then its code will
      be imported instead.
      
      For the last couple of releases this has been a reliable source
      of extension bug reports after major GNOME updates. Thankfully
      chrome-gnome-shell removed its update support in favor of our
      built-in support now, but users may still use older versions
      or perform those actions manually, so it still makes sense to
      catch this case and set an appropriate error.
      
      !1248
      6ddd43f3
    • Florian Müllner's avatar
      dateMenu: Remove unused property · 4e2ae30a
      Florian Müllner authored
      This is a left-over from an earlier iteration where the session's
      presence status was used rather than the GSetting.
      
      #2796
      4e2ae30a
    • Florian Müllner's avatar
      calendar: Fix initial do-not-disturb state · 32bc064d
      Florian Müllner authored
      The do-not-disturb button and the contained switch are
      tied together via a bidirectional property binding.
      
      However it still matters which objects are used as source
      and target, as that will determine the initial state: Right
      now the (unchecked) button is used as source, which means
      that do-not-disturb is turned off on startup.
      
      We want the state to be preserved, so swap source and target
      to let the switch (that is bound to the underlying GSetting)
      control the initial state.
      
      #2804
      32bc064d
    • Peter Simonyi's avatar
      status: Pass scroll events to volume and brightness sliders · 87606c6a
      Peter Simonyi authored
      Sliders can be operated by mouse scroll, but the mouse has to be over
      the slider control.  Make the brightness and volume system menu entries
      forward scroll events to the sliders they contain so that scrolling
      anywhere on the menu item operates the slider.
      
      Closes #2795
      87606c6a
  6. 17 May, 2020 1 commit
  7. 16 May, 2020 3 commits
  8. 15 May, 2020 2 commits
  9. 14 May, 2020 3 commits
  10. 13 May, 2020 4 commits
  11. 12 May, 2020 3 commits
  12. 11 May, 2020 2 commits