GitLab

Update NEWS.

Part-of: <!1981>

Update NEWS.

Part-of: <GNOME/gnome-shell!1976>

Florian Müllner authored Sep 06, 2021 and Marge Bot committed Sep 07, 2021

St's theme test now requires the libmutter-test library, which is only
built when tests are enabled. Instead of mandating a particular build
configuration in mutter, add a corresponding option in gnome-shell as
well.

Part-of: <!1975>

Florian Müllner authored Sep 06, 2021 and Marge Bot committed Sep 07, 2021

We currently just call sassc, but don't check its return value. That
means as long as sassc is available, the script (and therefore the
newly added dist CI job) will succeed.

Make sure we fail on failure.

Part-of: <!1974>

Update NEWS.

Part-of: <!1971>

So far, releases are done locally by invoking `meson dist`.

We can do better and leverage the existing CI infrastructure, to get
to the following release workflow:

 - bump version in meson.build, update NEWS etc.
 - open merge request for the release
 - merge when the pipeline (including dist check) succeeds
 - tag the release
 - wait for the tag pipeline to spit out the tarball artifact

Part-of: <!1968>

Most GNOME projects have settled on a 2-space indentation, so switch
to that. This will ease the ongoing copy+paste between projects :-)

Part-of: <!1968>

The time we really care about current release information in appdata is
when preparing a release, not during regular builds.

Part-of: <!1968>

I don't think this ever happened to me, but it can't hurt enforcing
that every release has a corresponding NEWS entry.

Part-of: <!1968>

It got replaced by `meta_window_actor_paint_to_content()`.

Part-of: <!1879>

Robert Mader authored Jun 06, 2021 and Marge Bot committed Sep 04, 2021

Previously we used `get_image()`, which returned `cairo_surface`,
in order to create a `ClutterContent` with a screenshot of the
`MetaWindowActor`. This added a roundtrip from GPU to CPU memory.

Instead, use the new `paint_to_content()` API which lets us use a
`CoglTexture` directly as source of our `ClutterContent`.

Part-of: <!1879>

Carlos Garnacho authored Jul 27, 2021 and Marge Bot committed Sep 03, 2021

This signal announces the preferred commit mode of the preedit text when
the input context is reset. Keep this mode around, and ensure to honor this
mode (e.g. maybe commit the preedit string) whenever the input method would
be reset.

This is delegated to the internal layers, so propagate this mode via
clutter_input_method_set_preedit_text().

Part-of: <!1929>

Florian Müllner authored Jun 16, 2021 and Marge Bot committed Sep 03, 2021

The shell D-Bus API was always meant as a private API for core
components, so enforce that by limiting caller to a list of
allowed well-known names.

Applications that want to request a screenshot can use the corresponding
desktop portal.

#3943

Part-of: <!1970>

Florian Müllner authored Jun 17, 2021 and Marge Bot committed Sep 03, 2021

The org.gnome.Shell interface provides a private API to other core
components to implement desktop functionalities like Settings or
global keybindings. It is not meant as a public API, so limit it
to a set of expected callers.

#3943

Part-of: <!1970>

Florian Müllner authored Jun 17, 2021 and Marge Bot committed Sep 03, 2021

In order to restrict callers, we will need access to the invocation,
not just the unpacked method parameters.

#3943

Part-of: <!1970>

Florian Müllner authored Jun 16, 2021 and Marge Bot committed Sep 03, 2021

Restricting callers to a list of allowed senders is useful for
other D-Bus services as well, so split out the existing code
into a reusable class.

#3943

Part-of: <!1970>

Florian Müllner authored Sep 01, 2021 and Marge Bot committed Sep 03, 2021

#3943

Part-of: <!1970>

Florian Müllner authored Sep 01, 2021 and Marge Bot committed Sep 03, 2021

The property was added precisely for this purpose, except that its
name isn't tied to the introspect API.

#3943

Part-of: <!1970>

Florian Müllner authored Sep 02, 2021 and Marge Bot committed Sep 03, 2021

If we throw an error when the invocation isn't allowed instead of
returning false, we can simply return that error instead of duplicating
the error handling.

Part-of: <!1970>

Florian Müllner authored Jun 17, 2021 and Marge Bot committed Sep 03, 2021

The Eval() method is unarguably the most sensitive D-Bus method
we expose, since it allows running arbitrary code in the compositor.

It is currently tied to the `development-tools` settings that is
enabled by default. As users have become accustomed to the built-in
commands that are enabled by the same setting (restart, lg, ...),
that default cannot easily be changed.

In order to restrict the method without affecting the rather harmless
commands, guard it by the new MetaContext:unsafe-mode property instead
of the setting.

#3943

Part-of: <!1970>

Florian Müllner authored Sep 02, 2021 and Marge Bot committed Sep 03, 2021

MetaContext added an unsafe-mode property, which we will use to restrict
a number of privileged operations unless it is enabled. It is meant to
only be enabled temporarily for development/debugging purposes, so add
a scary icon to the top bar as a reminder to turn it off again.

#3943

Part-of: <!1970>

Florian Müllner authored Sep 01, 2021 and Marge Bot committed Sep 01, 2021

Commit 16d37187 lifted the requirement for source actors to be
widgets, then got it wrong 🙄

The content box is expected to be in actor coordinates, so the
allocation must be translated to (0, 0).

#4593

Part-of: <!1969>