Commit 1bb0e1b9 authored by Florian Müllner's avatar Florian Müllner Committed by Marge Bot

extensions-app: Explicitly dispose window when removed

Unlike in previous GTK version (or Clutter), destroy() no longer
breaks reference cycles but just releases the reference held by
GTK itself.

So any reference we hold - either the explicit property or any signal
handlers that bind the window as `this` - prevents the window from
being disposed when closed, and the application won't quit.

Work around this by explicitly running dispose() on the window when
it is removed from the application.

Part-of: <!1495>
parent 3af90918
......@@ -42,6 +42,8 @@ class Application extends Gtk.Application {
_init() {
super._init({ application_id: 'org.gnome.Extensions' });
this.connect('window-removed', (a, window) => window.run_dispose());
get shellProxy() {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment