Skip to content

window-list: Pass the actor as PopupMenuManager owner

Marco Trevisan requested to merge 3v1n0/gnome-shell-extensions:window-list-menu-manager-grab-fix into master

PopupMenuManager's grabHelper starting from gnome-shell@7bb84dae must be an actor, so pass it explicitly instead of expecting the shell to do it for us.

This fixes an error during pushModal that was causing a grab not to be released.

The JS stacktrace was:

(gnome-shell:14542): Gjs-WARNING **: 14:08:48.367: JS ERROR: Exception in callback for signal: open-state-changed: TypeError: actor.connect is not a function
pushModal@/media/M2/GNOME/gnome-shell/js/ui/main.js:433:26
_takeModalGrab@/media/M2/GNOME/gnome-shell/js/ui/grabHelper.js:196:18
grab@/media/M2/GNOME/gnome-shell/js/ui/grabHelper.js:178:14
_onMenuOpenState@/media/M2/GNOME/gnome-shell/js/ui/popupMenu.js:1290:13
_emit@resource:///org/gnome/gjs/modules/signals.js:142:27
open@/media/M2/GNOME/gnome-shell/js/ui/popupMenu.js:881:9
_openMenu@/opt/dev/GNOME/share/gnome-shell/extensions/window-list@gnome-shell-extensions.gcampax.github.com/extension.js:35:5
_onClicked@/opt/dev/GNOME/share/gnome-shell/extensions/window-list@gnome-shell-extensions.gcampax.github.com/extension.js:352:13
Edited by Marco Trevisan

Merge request reports