Skip to content

Keybindings grabbing rework

Benjamin Berg requested to merge wip/benzea/keybindings-grabbing-rework into master

This is on top of !85 (merged). It requires gnome-shell!429 (merged).

I believe this may fix issues like reported in #151 (closed) (looking at the old code, there seem to be a number of things that look somewhat racy). However, the main reason to do this is that this is in preparation for #142 (closed).

I have tested this the most special cases in the code. i.e. changing a keybinding works, login works, cancellation works and daemon shutdown results in proper de-registration of all keybindings before the daemon quits (it does not wait for a response).

Merge request reports