Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G gnome-settings-daemon
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 316
    • Issues 316
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-settings-daemon
  • Issues
  • #218
Closed
Open
Issue created Jul 24, 2013 by Bugzilla@bugzilla-migration💬Reporter

Check return value of g_dbus_connection_register_object(), use GCancellable

Submitted by David King @davidk

Link to original bug (#704785)

Description

As noticed by Bastien in bug 692771, comment 20, some uses of g_dbus_connection_register_object() do not check the return value, where 0 indicates an error. The orientation plugin is one such example:

plugins/orientation/gsd-orientation-manager.c:354

Just below that call, there is a g_dbus_proxy_new() which should use a GCancellable, as should the g_bus_get() call on line 447.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking