1. 14 May, 2021 3 commits
  2. 12 May, 2021 1 commit
  3. 10 May, 2021 1 commit
  4. 25 Apr, 2021 1 commit
  5. 23 Apr, 2021 1 commit
  6. 14 Apr, 2021 4 commits
    • Benjamin Berg's avatar
      Release 40.0.1 · f33abac1
      Benjamin Berg authored
      f33abac1
    • Nishal Kulkarni's avatar
      night-light: Minor get_property fix · f80f9938
      Nishal Kulkarni authored
      Current behavior:
      `gsd_night_light_get_property` function would set the wrong value,
      value for PROP_SUNSET and PROP_TEMPERATURE was set to cached_sunrise
      
      Minor Fix:
      For PROP_SUNSET case set value to cached_sunset.
      For PROP_TEMPERATURE case set value to cached_temperature.
      f80f9938
    • Benjamin Berg's avatar
      rfkill: Do not sync state immediately when opening rfkill · 1ec87c5e
      Benjamin Berg authored
      We are opening the device asynchronously anyway. There is really no need
      to sync the state immediately, we can simpl rely on the POLL handler to
      do so later on from the mainloop.
      
      The difference we should see is that the debug information about there
      being no rfkill devices is gone. And, that some of the debug messages
      will be slightly different.
      1ec87c5e
    • Benjamin Berg's avatar
      rfkill: Fix rfkill event read length check · f6ce8d3f
      Benjamin Berg authored
      The kernel may return a short read for rfkill events in case it is using
      an older API version while g-s-d was compiled using the newer struct. As
      this is perfectly valid, we need to check the read length against
      RFKILL_EVENT_SIZE_V1 rather than the size of the struct.
      f6ce8d3f
  7. 13 Apr, 2021 1 commit
    • Hans de Goede's avatar
      rfkill: set the g_io_channel to unbuffered mode · d7a414cb
      Hans de Goede authored
      Access to a /dev/foo device should never use buffered mode.
      
      While debugging a gsd-rfkill issue I noticed in the g_debug output
      that the rfkill-glib.c code now seems to be receiving bogus events.
      
      Doing a strace I noticed some read(dev_rfkill_fd, buf, 8) calls,
      even though we call:
        g_io_channel_read_chars(..., sizeof(struct rfkill_event, ...)
      
      Which requests 9 bytes. The problem is the kernel expects us to
      read 1 event per read() system-call and it will throw away
      excess data. The idea is here that the rfkill_event struct can
      be extended by adding new fields at the end and then userspace code
      compiled against older kernel headers will still work since it
      will only read the fields it knows in a single call and the
      extra fields are thrown away.
      
      Since the rfkill-glib.c code was using buffered-io and asking
      g_io_channel_read_chars for 9 bytes when compiled against recent
      kernel headers, what would happen is that 2 events would be consumed
      in 2 read(fd, buf, 8) syscalls and then the first byte of the
      second event read would be appended to the previous event and
      the remaining 7 bytes would be used as the first 7 bytes for the
      next event (and eventually completed with the first 2 bytes of
      the next event, etc.). Leading to completely bogus events.
      
      Enabling unbuffered mode fixes this.
      
      Note this is a relatively new problem, caused by the kernel
      recently extending the rfkill_event struct with an extra byte-field:
      "rfkill: add a reason to the HW rfkill state"
      https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=14486c82612a177cb910980c70ba900827ca0894
      
      Before that kernel change the rfkill_event struct was 8 bytes large
      which allowed us to get away with using buffered io here.
      d7a414cb
  8. 07 Apr, 2021 1 commit
  9. 03 Apr, 2021 1 commit
  10. 27 Mar, 2021 1 commit
  11. 25 Mar, 2021 1 commit
  12. 23 Mar, 2021 1 commit
  13. 21 Mar, 2021 1 commit
  14. 14 Mar, 2021 2 commits
  15. 24 Feb, 2021 1 commit
  16. 21 Feb, 2021 1 commit
  17. 15 Feb, 2021 5 commits
  18. 14 Feb, 2021 4 commits
    • Carlos Garnacho's avatar
      Release 40.beta · 5743b91b
      Carlos Garnacho authored
      5743b91b
    • Dylan Van Assche's avatar
      power: close idleness notifications before suspending · c0b10fd4
      Dylan Van Assche authored
      Power-manager's idle notifications trigger the notification LED
      on the PinePhone which causes additional power consumption.
      c0b10fd4
    • Florian Müllner's avatar
      media-keys: Shut up a compiler warning · 93a74508
      Florian Müllner authored
      Apparently gcc is unhappy that a switch statement doesn't handle future
      enum additions:
      
      warning: ‘action’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      
      Shut it up with an appropriate default case.
      93a74508
    • Benjamin Berg's avatar
      plugins: Use Restart=on-failure even for XSettings plugin · a119fdaf
      Benjamin Berg authored
      The move to use Restart=on-abnormal happened because gsd-xsettings would
      die if Xwayland shuts down. However, since gnome-shell commit 01a927f388
      and related changes, we should be waiting for gsd-xsettings to shut down
      gracefully before Xwayland is stopped.
      
      As such, we should only hit an exit failure if from gsd-xsettings if
      Xwayland crashes. If gnome-shell follows up with a stop of the services
      within 100ms, then such a restart will not even be attempted.
      a119fdaf
  19. 09 Feb, 2021 1 commit
  20. 27 Jan, 2021 1 commit
    • Florian Müllner's avatar
      media-keys: Don't plonk on screenshot errors · d8112781
      Florian Müllner authored
      From a user's point of view, it doesn't matter whether gnome-shell's
      screenshot API returned `false` or a D-Bus error: Both mean that
      a screenshot was not taken.
      
      Treating them differently is therefore slightly confusing, so stop
      doing that: Rely on the lack of flash effect and shutter sound as
      feedback and remove the "plonk" sound played after errors.
      d8112781
  21. 23 Jan, 2021 1 commit
  22. 16 Jan, 2021 4 commits
  23. 15 Jan, 2021 2 commits