Carlos Garnacho (64904446) at 17 Mar 01:13
Release 46.0
Carlos Garnacho (8ff41960) at 17 Mar 01:12
Release 46.0
Yup, but providing a reason to the user ;-)
I suppose you could also argue that one should instead add a Requires=org.gnome.settingsdaemon.screensaverproxy.service
into the USB protection service. Or, somehow talk to the shell directly possibly.
g_error()
causes the program to immediately crash ;)
Yeah, maybe just do a g_error
instead of crashing? At the end, in this case the user misconfigured their system and didn't realise that USB protection needs information about the screensaver to work.
this happens to me when i disable org.gnome.settingsdaemon.screensaverproxy.target (and service) (aka: gsd-screensaver-proxy) on debian 12 bookworm gnome. my goal was that i didnt want any screensaver stuff, but, hey, i want usb protection.
See the commit messages for details.
Unfortunately this doesn’t bring gnome-settings-daemon down to zero deprecation warnings for me, as CUPS and ModemManager both have API deprecations which I have not tried to tackle. It does reduce the number of deprecation warnings, though.
It necessarily bumps the GLib dependency to 2.70, which is widely available (Debian Stable ships 2.74).
Signed-off-by: Philip Withnall pwithnall@gnome.org
Carlos Garnacho (e7e4b8bd) at 14 Mar 16:14
rfkill: Fix use of deprecated g_memdup()
... and 6 more commits
Done
Please rebase :), as all the changes look great to me
I am happy to rebase this to fix merge conflicts, but will only do so after it’s reviewed, or if a review is incoming. Otherwise it’s just busy-work. Let me know.
I feel like I shouldn't be the person making a final decision on this. It's my opinion and that's it. In any case, we need a plan on how to deal with the cases where the heuristics didn't work correctly. What's the plan here?
I have installed elogind-252.23
mkdir build
cd build
CFLAGS="$SLKCFLAGS" \
CXXFLAGS="$SLKCFLAGS" \
meson setup .. \
--buildtype=release \
--infodir=/usr/info \
--libdir=/usr/lib${LIBDIRSUFFIX} \
--libexecdir=/usr/libexec \
--datadir=/usr/share \
--bindir=/usr/bin \
--sbindir=/usr/sbin \
--includedir=/usr/include \
--localstatedir=/var \
--mandir=/usr/man \
--prefix=/usr \
--sysconfdir=/etc \
-Ddefault_library=shared \
-Dsystemd=false \
-Dstrip=true
"${NINJA:=ninja}"
DESTDIR=$PKG $NINJA install
cd ..
This is the meson command that I am using to build gnome-settings-daemon with your patch, I am building this on Slackware 15.1 Current
I'm not totally sure of what are you doing with this. But we have it compiling in alpine linux with 46.rc and this commit.
Updated for 46.rc
As mentioned in the commit e755ec7b , I actually linked gnome-settings-daemon to elogind for the systemd session management and it works.
[98/266] Compiling C object plugins/sh.../gsd-sharing.p/gsd-sharing-manager.c.o
FAILED: plugins/sharing/gsd-sharing.p/gsd-sharing-manager.c.o
ccache cc -Iplugins/sharing/gsd-sharing.p -Iplugins/sharing -I../plugins/sharing -I. -I.. -Iplugins/common -I../plugins/common -Ignome-setti
ngs-daemon -I../gnome-settings-daemon -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/us
r/lib64/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/webp -I/usr/include/libnm -fdiagnostics-color=
always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -DHAVE_CONFIG_H -DG_DISABLE_CAST_CHECKS -O2 -fPIC -pthread '-DG_LOG_DOMAIN="sharing-pl
ugin"' '-DPLUGIN_NAME="sharing"' '-DPLUGIN_DBUS_NAME="org.gnome.SettingsDaemon.Sharing"' '-DGNOME_SETTINGS_LOCALEDIR="/usr/share/locale"' -M
D -MQ plugins/sharing/gsd-sharing.p/gsd-sharing-manager.c.o -MF plugins/sharing/gsd-sharing.p/gsd-sharing-manager.c.o.d -o plugins/sharing/g
sd-sharing.p/gsd-sharing-manager.c.o -c ../plugins/sharing/gsd-sharing-manager.c
../plugins/sharing/gsd-sharing-manager.c:23:10: fatal error: systemd/sd-login.h: No such file or directory
23 | #include <systemd/sd-login.h>
| ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
[109/266] Compiling C object plugins/m...edia-keys.p/gsd-media-keys-manager.c.o
ninja: build stopped: subcommand failed.
bash-5.2#
Building with elogind instead of systemd produces this error.
This patch allows gnome-settings-daemon to link to elogind and use the systemd session management !348`
This is a small simplification, and allows to build against elogind without patches
Carlos Garnacho (e755ec7b) at 13 Mar 11:14
meson: use systemd option to decide whether dependencies are required