1. 22 Jul, 2016 1 commit
    • Hanno Böck's avatar
      main: fix heap overflow in dbus-launch wrapping · 7ee3571c
      Hanno Böck authored
      I have discovered a heap overflow with the help of an address sanitizer.
      
      The require_dbus_session() function has this code:
      
              new_argv = g_malloc (argc + 3 * sizeof (*argv));
      
      The intention is to allocate space for (argc + 3) pointers. However obviously a
      parenthesis is missing, therefore only argc bytes + 3 * pointer size gets
      allocated, which is insufficient space. This leads to invalid memory writes.
      
      The fix is trivial: Parentheses around argc + 3.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=768441
      7ee3571c
  2. 21 Jul, 2016 1 commit
  3. 01 Jul, 2016 2 commits
  4. 30 Jun, 2016 2 commits
  5. 20 Jun, 2016 2 commits
  6. 14 Jun, 2016 1 commit
  7. 02 Jun, 2016 1 commit
  8. 30 May, 2016 1 commit
  9. 26 May, 2016 3 commits
  10. 25 May, 2016 1 commit
  11. 09 May, 2016 5 commits
  12. 28 Apr, 2016 1 commit
  13. 27 Apr, 2016 1 commit
  14. 09 Apr, 2016 8 commits
  15. 08 Apr, 2016 1 commit
  16. 01 Apr, 2016 1 commit
  17. 31 Mar, 2016 1 commit
    • Andreas Henriksson's avatar
      main: fix starting gnome session via startx · 890a797a
      Andreas Henriksson authored
      The changes related to gsm_util_setenv during 3.19.x seems to have
      broken starting a gnome desktop the old fashioned way, eg. via startx.
      
      The gnome.session required components has OnlyShowIn=GNOME; which
      disqualifies them from being started unless XDG_CURRENT_DESKTOP is also
      set to GNOME (by the gio utility function used to look up info).
      
      Currently gnome-session already carries code to catch the case of
      XDG_CURRENT_DESKTOP being unset and set it to GNOME as a fallback.
      Unfortunately the changes to gsm_util_setenv seems to have made it only
      set the values in the (dbus activated) child environment, rather than
      the current environment which g_desktop_app_info_get_show_in is looking
      at.
      
      Make the fallback code set XDG_CURRENT_DESKTOP in both current
      and child environment fixes it.
      Also move the entire hunk of code before initializing gio to
      prevent potential thread issues, now that is uses g_setenv.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=764379
      890a797a
  18. 21 Mar, 2016 1 commit
  19. 20 Mar, 2016 1 commit
  20. 17 Mar, 2016 2 commits
  21. 14 Mar, 2016 2 commits
  22. 13 Mar, 2016 1 commit