This reverts commit db1a97c2

Ray Strode authored Nov 19, 2019 and Ray Strode committed Jan 12, 2022

Users sometimes set their shell to an invalid shell to prevent
login from proceeding.

GNOME on Wayland still allows login in these cases.

This commit makes the behavior match expectations by skipping
shell validity checks when deciding to run though a login shell.

Explicitly setting the variable to an empty string is a bit more more readable.
See https://www.shellcheck.net/wiki/SC1007

At the moment, gnome-session explicitly sets the various LC_ variables
to the user configured region.

That's unnecessary, though.  If the LC_ variables are unset,
applications know to use LANG.  Furthermore, setting the LC_ variables
makes it so you can't override them with LANG anymore.

This commit makes sure the LC_ variables only get set when absolutely
necesary. That is, when they are different than LANG.

#37

When gnome-session is invoked with G_MESSAGES_DEBUG=all set, $REGION
will also contain dconf's debug output:

    $ G_MESSAGES_DEBUG=all gsettings get org.gnome.system.locale region
    (process:14005): dconf-DEBUG: 15:59:46.581: watch_fast: "/system/locale/" (establishing: 0, active: 0)
    'de_DE.UTF-8'
    (process:14005): dconf-DEBUG: 15:59:46.582: unwatch_fast: "/system/locale/" (active: 0, establishing: 1)

Avoid that by setting G_MESSAGES_DEBUG empty.

Iñigo Martínez authored Sep 17, 2017 and Bastien Nocera committed Nov 16, 2017

meson is a build system focused on speed an ease of use, which
helps speeding up the software development. This patch adds meson
support along autotools.

https://bugzilla.gnome.org/show_bug.cgi?id=787806

Users expect their shell profiles to get sourced at startup, which
doesn't happen with wayland sessions.

This commit brings back that feature, by making the gnome-session
wrapper script run a login shell.

https://bugzilla.gnome.org/show_bug.cgi?id=736660

dbus-update-activation-environment excepts certain environment
variables, that systemd won't.  We're going to want to eventually send
the environment to systemd, too, so we shouldn't make sure the same set
of variables get sent to both.

This commit takes the dbus-update-activation-environment call out of the
gnome-session shell script wrapper, and instead changes the C code to do
the export explicitly.

https://bugzilla.gnome.org/show_bug.cgi?id=736660

This reverts commit 5e36cd63.

https://bugzilla.gnome.org/show_bug.cgi?id=736660

Users expect their shell profiles to get sourced at startup, which
doesn't happen with wayland sessions.

This commit brings back that feature, by making the gnome-shell
wrapper script run a login shell.

https://bugzilla.gnome.org/show_bug.cgi?id=736660

Apparently dash doesn't support >& and some people use dash.

This commit changes it to the more wordy form > ... 2>&1 .

https://bugzilla.gnome.org/show_bug.cgi?id=770363

dbus-update-activation-environment was introduced with dbus 1.10.4
gnome-session by itself does not depend on any specific version of
dbus at all - but on dbus-glib-1 (DBUS_GLIB_REQUIRED=0.76)

The latest version of dbus-glib (ver 106) requires dbus-1 1.8: it is
thus a valid setup to run not have dbus-update-activation-environment
on the system. Warning the user about its absence is alerting users
for not reason.

I had a think-o and where it should be placed in the script.

https://bugzilla.gnome.org/show_bug.cgi?id=766176

The dbus daemon gets started before some environment variables
are set at start up.

This commit makes sure the dbus daemon is given a clean snapshot
of the environment at the time the session is started.

This is a near-term workaround for

https://github.com/alexlarsson/xdg-app/issues/147

and will probably go away when we figure out a story for bug 736660

https://bugzilla.gnome.org/show_bug.cgi?id=766176

Before anything else runs

https://bugzilla.gnome.org/show_bug.cgi?id=756324