GitLab

gnome-setting-daemon now has a feature that controls USBGuard to
protect against USB-borne attacks.
In order to make use of that feature (although it currently still needs
to be activated manually), let's start the plugin with the session.
gnome-settings-daemon!75

It's common for projects to include "GNOME" in the name - this is less
ambiguous.

We discussed this at FOSDEM. Since we're both working on systemd-session
stuff at the minute, and most planned GNOME Session changes relate to
this, it makes sense for us to be able to review each other's work.

(cherry picked from commit 9c7acf56)

Now we're started by systemd, we also need to handle being *stopped* by
systemd too. systemd sends us a SIGTERM to ask us to quit, but we refuse
to exit on SIGTERM if we're not fully running. That's a problem if the
SIGTERM is sent early in startup. For example, if gnome-shell has exited
due to Wayland not being supported, and we're trying to fall back to
Xorg, the session will not be running at this point, but we want to be
able to kill everything in order to try again with Xorg.

Fix this by looking at the `GError` returned by `gsm_manager_logout()`,
and directly quitting if we're not in the running phase yet.

The idea was that this is useful for gnome-shell to modify its OnFailure
behaviour. However, the approach has been causing issues with session
shutdown and the workaround is quite complicated.

To simplify matters, the logic has been moved to gnome-shell and further
improved. As such, the gnome-session-stable.timer has lost its purpose
and it is unlikely to be useful for other purposes in the future.

Remove it completely.

See gnome-shell!858 and #43

This was part of some experimentations and got committed accidentally.
The file was never installed into any system. Simply remove it again.

We cannot allow this as gnome-session would try to restore XSMP clients
that are already started using systemd, resuling in session failures.

Fixes: 41

Allowing this is problematic as gnome-session would try to restore XSMP
clients that are already started using systemd, resuling in session
failures.

See: #41

The X11 services need to be stopped together with the session. Add
corresponding Requisite/PartOf/Before entries.

The shutdown target has explicit conflicts on some user units, this
means that as long as it is active, it will keep those units loaded.

We could probably reverse the conflicts to prevent this from happening.
But, it makes sense to set StopWhenUnneeded=true anyway and doing so
also means that the corresponding units can be unloaded after logout.

So far the blacklisted variables were not actively striped from the
environment of XDG autostart applications. Update the code to explicitly
unset the variables, preventing e.g. NOTIFY_SOCKET to be leaked to
children.

Fixes: #36

Probably/possibily temporarily.

I think I need to do this to be able to make a release, while Ray is
out.

Systemd fixes

Closes #31

See merge request !23

Variables like GNOME_SHELL_SESSION_MODE may not always be set at login,
causing them to survive between session. Add a list of variables that
need to be unset, and explicitly unset them on the systemd side.

The list is taken from GDMs list of variables.

For debugging reason, --debug was passed to gnome-session-binary in the
systemd service file. This is not necessariy and just causes a lot of
debug spew to be logged on systems.

Simply remove it again.

Fixes: #31