• Leesoo Ahn's avatar
    main-toolbar: Enable the gear menu only when the item is loaded · 354f925d
    Leesoo Ahn authored
    The "app.gear-menu" GAction is enabled and disabled from both
    photos_application_actions_update and the MainToolbar when the mode
    changes. This makes things unpredictable by relying on the order in
    which the callbacks are invoked. Currently the MainToolbar was
    winning and rendering parts of commit 031df27c ineffective.
    
    Instead, this should only be handled in one place -
    photos_application_actions_update. It's a lot more fine-grained and
    informed than the MainToolbar itself. eg., the MainToolbar only knows
    about the mode changing to PREVIEW, but doesn't know whether the item
    has finished loading.
    
    This code was added in commit 7e12154b, and the above rationale
    held true even then. However, back then, the item's loading state was
    not looked at. This is probably why the problem got overlooked.
    
    !94
    354f925d
Name
Last commit
Last update
..
Makefile.am Loading commit data...
meson.build Loading commit data...
org.gnome.ShellSearchProvider2.xml Loading commit data...
photos-application.c Loading commit data...
photos-application.h Loading commit data...
photos-base-item.c Loading commit data...
photos-base-item.h Loading commit data...
photos-base-manager.c Loading commit data...
photos-base-manager.h Loading commit data...
photos-base-model.c Loading commit data...
photos-base-model.h Loading commit data...
photos-camera-cache.c Loading commit data...
photos-camera-cache.h Loading commit data...
photos-collection-icon-watcher.c Loading commit data...
photos-collection-icon-watcher.h Loading commit data...
photos-create-collection-icon-job.c Loading commit data...
photos-create-collection-icon-job.h Loading commit data...
photos-create-collection-job.c Loading commit data...
photos-create-collection-job.h Loading commit data...
photos-debug.c Loading commit data...
photos-debug.h Loading commit data...
photos-delete-item-job.c Loading commit data...
photos-delete-item-job.h Loading commit data...
photos-delete-notification.c Loading commit data...
photos-delete-notification.h Loading commit data...
photos-device-item.c Loading commit data...
photos-device-item.h Loading commit data...
photos-dleyna-renderer-device.xml Loading commit data...
photos-dleyna-renderer-manager.xml Loading commit data...
photos-dleyna-renderer-push-host.xml Loading commit data...
photos-dlna-renderer.c Loading commit data...
photos-dlna-renderer.h Loading commit data...
photos-dlna-renderers-dialog.c Loading commit data...
photos-dlna-renderers-dialog.h Loading commit data...
photos-dlna-renderers-dialog.ui Loading commit data...
photos-dlna-renderers-manager.c Loading commit data...
photos-dlna-renderers-manager.h Loading commit data...
photos-done-notification.c Loading commit data...
photos-done-notification.h Loading commit data...
photos-dropdown.c Loading commit data...
photos-dropdown.h Loading commit data...
photos-dropdown.ui Loading commit data...
photos-edit-palette-row.c Loading commit data...
photos-edit-palette-row.h Loading commit data...
photos-edit-palette.c Loading commit data...
photos-edit-palette.h Loading commit data...
photos-embed.c Loading commit data...
photos-embed.h Loading commit data...
photos-embed.ui Loading commit data...
photos-empty-results-box.c Loading commit data...
photos-empty-results-box.h Loading commit data...
photos-enums-gegl.c.template Loading commit data...
photos-enums-gegl.h.template Loading commit data...
photos-enums.c.template Loading commit data...
photos-enums.h.template Loading commit data...
photos-error-box.c Loading commit data...
photos-error-box.h Loading commit data...
photos-error.c Loading commit data...
photos-error.h Loading commit data...
photos-export-dialog.c Loading commit data...
photos-export-dialog.h Loading commit data...
photos-export-dialog.ui Loading commit data...
photos-export-notification.c Loading commit data...
photos-export-notification.h Loading commit data...
photos-facebook-item.c Loading commit data...
photos-facebook-item.h Loading commit data...
photos-fetch-collection-state-job.c Loading commit data...
photos-fetch-collection-state-job.h Loading commit data...
photos-fetch-collections-job.c Loading commit data...
photos-fetch-collections-job.h Loading commit data...
photos-fetch-ids-job.c Loading commit data...
photos-fetch-ids-job.h Loading commit data...
photos-fetch-metas-job.c Loading commit data...
photos-fetch-metas-job.h Loading commit data...
photos-filterable.c Loading commit data...
photos-filterable.h Loading commit data...
photos-flickr-item.c Loading commit data...
photos-flickr-item.h Loading commit data...
photos-gegl.c Loading commit data...
photos-gegl.gresource.xml Loading commit data...
photos-gegl.h Loading commit data...
photos-generate-about Loading commit data...
photos-gesture-zoom.c Loading commit data...
photos-gesture-zoom.h Loading commit data...
photos-glib.c Loading commit data...
photos-glib.h Loading commit data...
photos-gom-miner.xml Loading commit data...
photos-google-item.c Loading commit data...
photos-google-item.h Loading commit data...
photos-help-overlay.ui Loading commit data...
photos-image-view-helper.c Loading commit data...
photos-image-view-helper.h Loading commit data...
photos-image-view.c Loading commit data...
photos-image-view.h Loading commit data...
photos-import-dialog.c Loading commit data...
photos-import-dialog.h Loading commit data...
photos-import-dialog.ui Loading commit data...
photos-indexing-notification.c Loading commit data...
photos-indexing-notification.h Loading commit data...
photos-item-manager.c Loading commit data...
photos-item-manager.h Loading commit data...
photos-jpeg-count.c Loading commit data...
photos-jpeg-count.h Loading commit data...
photos-local-item.c Loading commit data...
photos-local-item.h Loading commit data...
photos-main-toolbar.c Loading commit data...
photos-main-toolbar.h Loading commit data...
photos-main-toolbar.ui Loading commit data...
photos-main-window.c Loading commit data...
photos-main-window.h Loading commit data...
photos-main-window.ui Loading commit data...
photos-main.c Loading commit data...
photos-marshalers.list Loading commit data...
photos-media-server-item.c Loading commit data...
photos-media-server-item.h Loading commit data...
photos-model-button.c Loading commit data...
photos-model-button.h Loading commit data...
photos-mpris-player.xml Loading commit data...
photos-notification-manager.c Loading commit data...
photos-notification-manager.h Loading commit data...
photos-offset-collection-view-controller.c Loading commit data...
photos-offset-collection-view-controller.h Loading commit data...
photos-offset-collections-controller.c Loading commit data...
photos-offset-collections-controller.h Loading commit data...
photos-offset-controller.c Loading commit data...
photos-offset-controller.h Loading commit data...
photos-offset-favorites-controller.c Loading commit data...
photos-offset-favorites-controller.h Loading commit data...
photos-offset-import-controller.c Loading commit data...
photos-offset-import-controller.h Loading commit data...
photos-offset-overview-controller.c Loading commit data...
photos-offset-overview-controller.h Loading commit data...
photos-offset-search-controller.c Loading commit data...
photos-offset-search-controller.h Loading commit data...
photos-operation-insta-common.h Loading commit data...
photos-operation-insta-curve.c Loading commit data...
photos-operation-insta-curve.h Loading commit data...
photos-operation-insta-filter.c Loading commit data...
photos-operation-insta-filter.h Loading commit data...
photos-operation-insta-hefe-curve.c Loading commit data...
photos-operation-insta-hefe-curve.h Loading commit data...
photos-operation-insta-hefe-vignette.c Loading commit data...
photos-operation-insta-hefe-vignette.h Loading commit data...
photos-operation-insta-hefe.c Loading commit data...
photos-operation-insta-hefe.h Loading commit data...
photos-operation-jpg-guess-sizes.c Loading commit data...
photos-operation-jpg-guess-sizes.h Loading commit data...
photos-operation-png-guess-sizes.c Loading commit data...
photos-operation-png-guess-sizes.h Loading commit data...
photos-operation-saturation.c Loading commit data...
photos-operation-saturation.h Loading commit data...
photos-operation-svg-multiply.c Loading commit data...
photos-operation-svg-multiply.h Loading commit data...
photos-organize-collection-dialog.c Loading commit data...
photos-organize-collection-dialog.h Loading commit data...
photos-organize-collection-model.c Loading commit data...
photos-organize-collection-model.h Loading commit data...
photos-organize-collection-view.c Loading commit data...
photos-organize-collection-view.h Loading commit data...
photos-overview-searchbar.c Loading commit data...
photos-overview-searchbar.h Loading commit data...
photos-pipeline.c Loading commit data...
photos-pipeline.h Loading commit data...
photos-pixbuf.c Loading commit data...
photos-pixbuf.h Loading commit data...
photos-png-count.c Loading commit data...
photos-png-count.h Loading commit data...
photos-preview-menu.ui Loading commit data...
photos-preview-nav-buttons.c Loading commit data...
photos-preview-nav-buttons.h Loading commit data...
photos-preview-view.c Loading commit data...
photos-preview-view.h Loading commit data...
photos-primary-menu.ui Loading commit data...
photos-print-notification.c Loading commit data...
photos-print-notification.h Loading commit data...
photos-print-operation.c Loading commit data...
photos-print-operation.h Loading commit data...
photos-print-preview.c Loading commit data...
photos-print-preview.h Loading commit data...
photos-print-setup.c Loading commit data...
photos-print-setup.h Loading commit data...
photos-properties-dialog.c Loading commit data...
photos-properties-dialog.h Loading commit data...
photos-quarks.c Loading commit data...
photos-quarks.h Loading commit data...
photos-query-builder.c Loading commit data...
photos-query-builder.h Loading commit data...
photos-query.c Loading commit data...
photos-query.h Loading commit data...
photos-remote-display-manager.c Loading commit data...
photos-remote-display-manager.h Loading commit data...
photos-removable-device-widget.c Loading commit data...
photos-removable-device-widget.h Loading commit data...
photos-removable-device-widget.ui Loading commit data...
photos-removable-devices-button.c Loading commit data...
photos-removable-devices-button.h Loading commit data...
photos-removable-devices-button.ui Loading commit data...
photos-search-context.c Loading commit data...
photos-search-context.h Loading commit data...
photos-search-controller.c Loading commit data...
photos-search-controller.h Loading commit data...
photos-search-match-manager.c Loading commit data...
photos-search-match-manager.h Loading commit data...
photos-search-match.c Loading commit data...
photos-search-match.h Loading commit data...
photos-search-provider.c Loading commit data...
photos-search-provider.h Loading commit data...
photos-search-type-manager.c Loading commit data...
photos-search-type-manager.h Loading commit data...
photos-search-type.c Loading commit data...
photos-search-type.h Loading commit data...
photos-searchbar.c Loading commit data...
photos-searchbar.h Loading commit data...
photos-selection-controller.c Loading commit data...
photos-selection-controller.h Loading commit data...
photos-selection-menu.ui Loading commit data...
photos-selection-toolbar.c Loading commit data...
photos-selection-toolbar.h Loading commit data...
photos-selection-toolbar.ui Loading commit data...
photos-set-collection-job.c Loading commit data...
photos-set-collection-job.h Loading commit data...
photos-share-dialog.c Loading commit data...
photos-share-dialog.h Loading commit data...
photos-share-dialog.ui Loading commit data...
photos-share-notification.c Loading commit data...
photos-share-notification.h Loading commit data...
photos-share-point-email.c Loading commit data...
photos-share-point-email.h Loading commit data...
photos-share-point-google.c Loading commit data...
photos-share-point-google.h Loading commit data...
photos-share-point-manager.c Loading commit data...
photos-share-point-manager.h Loading commit data...
photos-share-point-online.c Loading commit data...
photos-share-point-online.h Loading commit data...
photos-share-point.c Loading commit data...
photos-share-point.h Loading commit data...
photos-single-item-job.c Loading commit data...
photos-single-item-job.h Loading commit data...
photos-source-manager.c Loading commit data...
photos-source-manager.h Loading commit data...
photos-source-notification.c Loading commit data...
photos-source-notification.h Loading commit data...
photos-source.c Loading commit data...
photos-source.h Loading commit data...
photos-spinner-box.c Loading commit data...
photos-spinner-box.h Loading commit data...
photos-thumbnail-factory.c Loading commit data...
photos-thumbnail-factory.h Loading commit data...
photos-thumbnailer-dbus.xml Loading commit data...
photos-thumbnailer-main.c Loading commit data...
photos-thumbnailer.c Loading commit data...
photos-thumbnailer.h Loading commit data...
photos-tool-colors.c Loading commit data...
photos-tool-colors.h Loading commit data...
photos-tool-crop-helper.c Loading commit data...
photos-tool-crop-helper.h Loading commit data...
photos-tool-crop.c Loading commit data...
photos-tool-crop.h Loading commit data...
photos-tool-enhance.c Loading commit data...
photos-tool-enhance.h Loading commit data...
photos-tool-filter-button.c Loading commit data...
photos-tool-filter-button.h Loading commit data...
photos-tool-filters.c Loading commit data...
photos-tool-filters.h Loading commit data...
photos-tool.c Loading commit data...
photos-tool.h Loading commit data...
photos-tracker-change-event.c Loading commit data...
photos-tracker-change-event.h Loading commit data...
photos-tracker-change-monitor.c Loading commit data...
photos-tracker-change-monitor.h Loading commit data...
photos-tracker-collection-view-controller.c Loading commit data...
photos-tracker-collection-view-controller.h Loading commit data...
photos-tracker-collections-controller.c Loading commit data...
photos-tracker-collections-controller.h Loading commit data...
photos-tracker-controller.c Loading commit data...
photos-tracker-controller.h Loading commit data...
photos-tracker-extract-priority.xml Loading commit data...
photos-tracker-favorites-controller.c Loading commit data...
photos-tracker-favorites-controller.h Loading commit data...
photos-tracker-import-controller.c Loading commit data...
photos-tracker-import-controller.h Loading commit data...
photos-tracker-overview-controller.c Loading commit data...
photos-tracker-overview-controller.h Loading commit data...
photos-tracker-queue.c Loading commit data...
photos-tracker-queue.h Loading commit data...
photos-tracker-resources.xml Loading commit data...
photos-tracker-search-controller.c Loading commit data...
photos-tracker-search-controller.h Loading commit data...
photos-update-mtime-job.c Loading commit data...
photos-update-mtime-job.h Loading commit data...
photos-utils.c Loading commit data...
photos-utils.h Loading commit data...
photos-view-container.c Loading commit data...
photos-view-container.h Loading commit data...
photos-zoom-controls.c Loading commit data...
photos-zoom-controls.h Loading commit data...
photos-zoom-controls.ui Loading commit data...
photos.gresource.xml Loading commit data...