1. 09 Aug, 2018 3 commits
  2. 03 Aug, 2018 1 commit
  3. 01 Aug, 2018 2 commits
    • Debarshi Ray's avatar
    • Debarshi Ray's avatar
      build: Turn off -Wcast-function-type · bb290a1e
      Debarshi Ray authored
      GCC 8 introduced -Wcast-function-type. It is enabled by -Wextra, which
      is on the AX_COMPILER_FLAGS list. Unfortunately, this cannot be sanely
      used with the GNOME platform. It is exceedingly common practice to
      specify a function as a callback that ignores some of the trailing
      parameters passed to it. In fact, the following snippet that's part of
      the g_list_copy_deep documentation triggers -Wcast-function-type:
        another_list = g_list_copy_deep (list,
                                         (GCopyFunc) g_object_ref,
      Disabling warnings like this does go against the recommendation of the
      AX_COMPILER_FLAGS documentation, which suggests the use of #pragmas
      instead. However, unlike passing the flags through the command line,
      attempts to ignore -Wcast-function-type through a #pragma will trigger
      -Wpragmas on older versions of GCC, and, ironically, using
      G_GNUC_CHECK_VERSION to conditionally disable it on newer compilers
      will trigger -Wexpansion-to-defined, again, because of -Wextra.
  4. 30 Jul, 2018 2 commits
    • Debarshi Ray's avatar
      build: Unbreak by adding missing definition of AX_APPEND_LINK_FLAGS · 0e546cda
      Debarshi Ray authored
      The second attempt at updating the AX_* macros in commit
      7ae86729 seem to have again broken the build:
        autoreconf: running: aclocal --force -I m4 -I libgd ${ACLOCAL_FLAGS}
        configure.ac:21: error: macro AX_APPEND_LINK_FLAGS is not defined;
          is a m4 file missing?
        m4/ax_require_defined.m4:35: AX_REQUIRE_DEFINED is expanded from...
        m4/ax_compiler_flags_ldflags.m4:30: AX_COMPILER_FLAGS_LDFLAGS is
          expanded from...
        m4/ax_compiler_flags.m4:113: AX_COMPILER_FLAGS is expanded from...
        configure.ac:21: the top level
      It is not clear why the build didn't break while testing commit
      7ae86729 or any of the subsequent ones after that. Continuous
      and the nightly Flatpak builds have also been chugging along without
      any problems. It's a mystery.
      Anyway, including the definition of AX_APPEND_LINK_FLAGS seems like
      the obvious thing to do.
    • Mathieu Bridon's avatar
  5. 28 Jul, 2018 3 commits
  6. 26 Jul, 2018 1 commit
    • Debarshi Ray's avatar
      flatpak: Simplify TrackerSparqlConnection creation · 6624c0c8
      Debarshi Ray authored
      The Tracker D-Bus services are not part of the Flatpak bundle and are
      accessed from the host operating system. This means that the Tracker
      database cannot be accessed "directly", which causes:
        Tracker-WARNING **: Falling back to bus backend, the direct backend
          failed to initialize: Could not open sqlite3 database:
          unable to open database file
      The database needs to be accessed via D-Bus. So far, this was being
      handled by the fallback error-handling code paths.
  7. 24 Jul, 2018 1 commit
  8. 18 Jul, 2018 5 commits
  9. 13 Jul, 2018 3 commits
  10. 09 Jul, 2018 1 commit
  11. 29 Jun, 2018 6 commits
  12. 28 Jun, 2018 6 commits
    • Debarshi Ray's avatar
      image-view: Reduce memory fragmentation · 491a1822
      Debarshi Ray authored
      Instead of allocating and de-allocating memory for the throwaway Cairo
      surface on every invocation of the GtkWidget::draw virtual method,
      allocate a memory area big enough to draw the entire widget and keep
      re-using it.
    • Debarshi Ray's avatar
      image-view: Rename variables for clarity · ed033da0
      Debarshi Ray authored
    • Debarshi Ray's avatar
      image-view: Rename variables for consistency · 2fcbfc0f
      Debarshi Ray authored
      Use "allocation" instead of "viewport" and "scaled" instead of "real".
    • Debarshi Ray's avatar
      base-item: Use the correct stride value · c3ef33ea
      Debarshi Ray authored
      The stride with which the Cairo surface is created should be the same
      as the one with which data was written to it. The Cairo surface and its
      underlying memory buffer were being created based on the stride
      specified by Cairo, while data was being written to it based on a
      potentially smaller stride value, which could have caused visual
      GEGL_AUTO_ROWSTRIDE represents the product of the bytes per pixel of
      the Babl format with the requested width. This might not match the
      value specified by the Cairo surface because it might be more
      performant to have extra padding at the end of each row to satisfy
      alignment requirements, etc..
      There are no known bugs caused by this, possibly because a
      CAIRO_ARGB32 pixel has a nicely rounded length of 32 bits, which makes
      a mismatch unlikely. However, the possibility cannot be ruled out.
      There was a similar bug in gegl:pixbuf [1] where the stride with which
      a GdkPixbuf was created didn't match the one with which data was read
      from it.
      [1] GEGL commit aaf2477caec750
    • Debarshi Ray's avatar
      image-view: Use the correct stride value · 15542a14
      Debarshi Ray authored
      Multiplying the bytes per pixel of the Babl format with the requested
      width is the same as GEGL_AUTO_ROWSTRIDE. Therefore, it makes no sense
      to pass an explicit stride if that's just the same thing as
      The correct value would be the one specified by the Cairo surface
      because ultimately the size of the allocated memory is defined by the
      product of the stride and height. Any mismatch between Cairo and
      GEGL_AUTO_ROWSTRIDE, due to extra padding at the end of each row to
      satisfy alignment requirements, etc., would affect performance.
      It's hard to know the performance impact of the current code, and
      a CAIRO_ARGB32 pixel has a nicely rounded length of 32 bits, which
      makes a mismatch unlikely. Still, it is wise to make this change
      because the Cairo documentation recommends this. For what it's worth,
      GIMP also uses the Cairo stride value when copying pixels out of a
      GeglBuffer into a Cairo surface.
    • Daniel Șerbănescu's avatar
      Update Romanian translation · d9da5902
      Daniel Șerbănescu authored
  13. 24 Jun, 2018 1 commit
  14. 21 Jun, 2018 1 commit
  15. 19 Jun, 2018 1 commit
  16. 18 Jun, 2018 2 commits
  17. 17 Jun, 2018 1 commit