Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • GNOME Photos GNOME Photos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 144
    • Issues 144
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GNOME PhotosGNOME Photos
  • Issues
  • #152
Closed
Open
Issue created May 30, 2020 by Sam Thursfield@sthursfieldDeveloper

Port to Tracker 3

See Initiatives#17 (closed) for background.

Photos makes heavy use of Tracker and there are several changes we'll need to make for it to work with Tracker 3. Here's what I think we need to do:

  • Port to libtracker-sparql 3.x API
  • Account for file & dataobjects being different resources in Tracker 3.x (modify photos-query-builder.c to query both the nmm:Photo and the nfo:FileDataObject resource)
  • Honour graph separation
    • Modify queries to only look at the tracker:Pictures graph
    • Set corresponding policy in the xdg-tracker-portal Flatpak portal
  • Store albums and favourites in a private Tracker database (in 2.x they were stored in the session-wide Tracker store, which no longer exists in 3.x) -- queries will need to updated too.
  • Replace TrackerMinerManager usage with direct call to IndexFile
    • Add a way to monitor progress of IndexFile call, so we can display a notification without trying to contact the Miner over D-Bus (which won't be possible in a sandbox)
  • Update Flatpak manifest to use Tracker from GNOME SDK (we might still include tracker-miners ... i'm not sure if it's useful or not inside the sandbox)

Also, we need a way to export albums and favourites from the Tracker 2 database, and import them to the new Photos app database. My initial attempt is here: tracker!262 (merged) and https://gitlab.gnome.org/sthursfield/tracker-data-migration-tools/

Some things I would like to do as part of this porting effort, but are not required:

  • #59 (closed) (use TrackerNotifier instead of monitoring GraphUpdated signal)
  • #83 (make online miners private to gnome-photos and include them in the Flatpak bundle)
  • improve testing
    • the dogtail test is currently broken
    • there's no test for any Tracker related codepaths
Edited Aug 26, 2020 by Sam Thursfield
Assignee
Assign to
Time tracking