1. 14 Mar, 2021 1 commit
  2. 13 Mar, 2021 1 commit
    • Debarshi Ray's avatar
      build, flatpak: Add an option for installing Flatpak-specific files · 5893dab9
      Debarshi Ray authored
      When running as a Flatpak, the application can use a private instance
      of Tracker 3's filesystem miner on hosts without Tracker 3. This
      requires a few extra files to be installed that are otherwise not
      necessary.
      
      This should make it easier for downstream distributors to ensure the
      correctness of builds, without having to understand too many details.
      
      !174
      5893dab9
  3. 12 Mar, 2021 2 commits
    • Debarshi Ray's avatar
      Prepare 40.beta · cb388d89
      Debarshi Ray authored
      cb388d89
    • Sam Thursfield's avatar
      Port to Tracker 3 · bd087d67
      Sam Thursfield authored
      Notable changes:
      
        * User data (favourites, albums) is now stored in a private database
          in ~/.local/share/gnome-photos. This is combined with the
          filesystem miner's index of items at query time.
      
        * Inside Flatpak, the application connects to Tracker via the new
          xdg-tracker-portal instead of talking directly over D-Bus. Access
          is limited by the portal so the app can only see the Pictures
          graph.
      
        * The Flatpak build can use a private instance of Tracker 3's
          filesystem miner when running on hosts without Tracker 3.
      
      Currently, nfo:fileName is absent from the tracker:Pictures graph [1],
      which leads to the following WARNING:
        gnome-photos-WARNING **: (../src/photos-local-item.c:91):
          photos_local_item_create_filename_fallback: code should not be
          reached
      
      Similarly, the built-in nfo:image-category-screenshot collection is
      also missing.
      
      [1] tracker#221
      
      #152
      bd087d67
  4. 15 Feb, 2021 1 commit
    • Christopher Davis's avatar
      photos-empty-results-box: Use HdyStatusPage · ed572985
      Christopher Davis authored
      HdyStatusPage is a prebuilt libhandy widget for empty status pages and
      the like. For consistency across GNOME we should use it.
      
      Also adjusts writing style to match other status pages.
      
      Bump minimum libhandy version to 1.1.90.
      
      !160
      ed572985
  5. 03 Feb, 2021 1 commit
  6. 10 Nov, 2020 1 commit
    • Debarshi Ray's avatar
      Add a manual · 22d3a336
      Debarshi Ray authored
      Note that the MESON_ARGS variable is now called CONFIG_OPTS [1,2].
      
      [1] CITemplates commit 0ef03c4ce77aa75d
      
      [2] CITemplates commit 45034800e5373e6b
      
      !153
      22d3a336
  7. 01 Oct, 2020 1 commit
  8. 22 Sep, 2020 1 commit
    • Sam Thursfield's avatar
      Switch to private instances of the Tracker 2.x daemons · fb31e2a8
      Sam Thursfield authored
      GNOME 3.38 is switching to Tracker 3.x by default [1]. However, Photos
      is not ready to switch this cycle.
      
      It's desirable to avoid having two sets of Tracker daemons indexing
      the same content as much as possible. One option is to start private
      instances of the Tracker 2.x daemons tied to the lifetime of the GNOME
      Photos application. Distributions can disable Tracker 2.x by default,
      and it will only be activated when needed by Photos.
      
      This also allows the Photos Flatpak to run Tracker 2.x daemons inside
      the sandbox, ensuring it works on systems which don't have Tracker 2.x
      available.
      
      Based on code written by Yi-Soo An.
      
      [1] Initiatives#17
      
      !146
      fb31e2a8
  9. 18 Sep, 2020 1 commit
  10. 08 Sep, 2020 1 commit
  11. 25 Aug, 2020 3 commits
  12. 24 Aug, 2020 2 commits
  13. 22 May, 2020 1 commit
  14. 20 Aug, 2019 2 commits
  15. 30 Jun, 2019 1 commit
  16. 30 May, 2019 1 commit
  17. 18 Mar, 2019 2 commits
  18. 21 Feb, 2019 1 commit
  19. 13 Dec, 2018 1 commit
  20. 30 Nov, 2018 1 commit
    • Debarshi Ray's avatar
      gegl: Add photos_gegl_pixbuf_new_from_buffer · 5f54518a
      Debarshi Ray authored
      This is part of a new set of APIs for GeglBuffer that don't require the
      creation of a graph. These will allow decoding and encoding image file
      formats to and from a GeglBuffer through asynchronous and cancellable
      methods with error handling. These will follow GIO idioms and be
      similar to the codec APIs for GdkPixbuf. There will be a compatibility
      layer to convert a GeglBuffer to and from GdkPixbuf for legacy reasons.
      
      These APIs will address the current lack of cancellation and error
      handling in gegl:load, and make it easier to port existing code away
      from GdkPixbuf.
      
      Bump minimum GdkPixbuf version to 2.36.8.
      5f54518a
  21. 23 Nov, 2018 1 commit
  22. 15 Nov, 2018 2 commits
  23. 02 Nov, 2018 1 commit
  24. 19 Oct, 2018 1 commit
    • Debarshi Ray's avatar
      build: Don't install COPYING · ef15cadb
      Debarshi Ray authored
      $datadir/doc or $docdir is not necessarily the right location to place
      the COPYING file. Some distributors might want to install it somewhere
      else. eg., Fedora RPMs [1] mark the license text with %license which
      puts it under $datadir/licenses. Currently, such a distributor has to
      go out of its way to not have two copies of the files.
      
      As a data point, GLib doesn't install its COPYING file either.
      
      Users can still see the license from the application's about dialog.
      
      [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines
      ef15cadb
  25. 13 Oct, 2018 1 commit
    • Debarshi Ray's avatar
      build: Avoid requiring Git for release tarballs · 45c49947
      Debarshi Ray authored
      It's a tad nicer to not require Git when building release tarballs.
      While Git is definitely widely available, it's just one more thing
      that would have to be installed in the buildroots. Therefore, it is
      avoided for 'plain' builds.
      
      !71
      45c49947
  26. 11 Oct, 2018 1 commit
    • Debarshi Ray's avatar
      build: Split some code into a private shared library · 37a598b0
      Debarshi Ray authored
      The overall idea is to start adding unit tests, wherever possible.
      Putting the tested code in a private library makes it accessible from
      test cases because they can link to it.
      
      Subsequent commits will add a new codec API for GeglBuffer. It will be
      very important to have unit tests for those code paths because:
        * That code will be inherently testable and tests are great.
        * That code is likely to be security sensitive, will handle all
          sorts of dodgy input from untrusted sources, and written using
          very old APIs with brittle error handling.
      
      This is a step towards that.
      
      A private shared library seems better than a private static archive
      because the most easily testable code paths are shared across the main
      application and the thumbnailer. Therefore, the assumption is that the
      benefits of sharing that code across both processes outweigh the
      drawbacks of having to resolve symbols from yet another shared library
      on startup. However, this is just an assumption. There's no data
      behind it.
      
      #63
      37a598b0
  27. 02 Oct, 2018 1 commit
  28. 28 Sep, 2018 1 commit
  29. 27 Sep, 2018 1 commit
    • Debarshi Ray's avatar
      build: Add the remaining -Wextra warnings in GCC 8 to the Meson build · 4e0a1502
      Debarshi Ray authored
      The Autotools build uses -Wextra because it's on the AX_COMPILER_FLAGS
      list. However, using -Wextra directly is problematic because newer
      compilers can add more warnings to the -Wextra umbrella, and some of
      them might not be fit for this codebase. eg., GCC 8 added
      -Wcast-function-type, which can't be sanely used with the GNOME
      platform (see commit bb290a1e). This is why the Meson build
      tries to avoid -Wextra. Instead, it is better to explicitly list out
      the desired warnings from the -Wextra umbrella.
      
      The warnings that were explicitly listed out in AX_COMPILER_FLAGS were
      already present in the initial port to Meson. This fills in the rest
      that weren't explicitly listed but were still enabled by -Wextra.
      4e0a1502
  30. 25 Sep, 2018 2 commits
  31. 06 Sep, 2018 1 commit
  32. 01 Sep, 2018 1 commit
    • Debarshi Ray's avatar
      Prepare 3.29.92 · 0b356bf7
      Debarshi Ray authored
      Owing to the last-minute nature of the port to the Meson build system,
      tarballs are still generated with Autotools to reduce the chances of
      any breakage.
      0b356bf7