1. 08 Sep, 2017 4 commits
  2. 07 Sep, 2017 4 commits
  3. 06 Sep, 2017 9 commits
  4. 05 Sep, 2017 13 commits
  5. 04 Sep, 2017 6 commits
  6. 03 Sep, 2017 1 commit
  7. 02 Sep, 2017 1 commit
  8. 30 Aug, 2017 2 commits
    • Debarshi Ray's avatar
      embed: Untangle the notify::visible-child & window-mode-changed logic · cacf92ff
      Debarshi Ray authored
      The purpose of the GtkStack::notify::visible-child handler is to change
      the WindowMode when the GtkStackSwitcher is used. That's only possible
      with a left-click or tapping the touchscreen.
      
      The ModeController::window-mode-changed handler is meant to do all
      that's necessary when the mode changes - setting up the widgets,
      saving application state, etc..
      
      So far, both the handlers would be invoked for every mode change
      regardless of whether the GtkStackSwitcher was used or not; but the
      order in which they ran was determined by the involvement of the
      GtkStackSwitcher. That's confusing.
      
      From now on, the photos_embed_notify_visible_child will ignore changes
      to the visible child unless it happened due to a left-click or touch
      event. The logic to determine whether to hide the searchbar or not has
      been moved to photos_embed_window_mode_changed because it is just like
      the rest of the window-mode-changed handling code, and has nothing to
      do with the GtkStackSwitcher.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=786936
      cacf92ff
    • Debarshi Ray's avatar
      embed: Simplify code · af37cfe1
      Debarshi Ray authored
      The purpose of the photos_embed_search_changed callback is to switch
      to the SEARCH mode when the user specifies any search criterion, and
      to switch back when she has lifted all criteria. It shouldn't interfere
      when the application is saving and restoring search state for internal
      state management.
      
      Therefore, instead of a mysterious comment and hard to understand
      conditions inside photos_embed_search_changed itself, it is simpler to
      temporarily block it whenever there is a change due to internal
      bookkeeping.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=786936
      af37cfe1