GitLab

See:
glib@7c7623c4
glib@0604f585
glib@83e48d8a
glib#600

!78

See:
glib@fab561f8
glib#600

!78

Enable automatic building of CI for gnome-online-accounts

Hugo Carvalho authored Jun 09, 2021 and Administrator committed Jun 09, 2021

(cherry picked from commit e4174f38)

Quentin PAGÈS authored May 10, 2021 and Administrator committed May 10, 2021

(cherry picked from commit 2d060356)

Pawan Chitrakar authored May 01, 2021 and Administrator committed May 01, 2021

(cherry picked from commit 96424860)

Pawan Chitrakar authored Apr 28, 2021 and Administrator committed Apr 28, 2021

(cherry picked from commit 4eb7fe53)

Fallout from 19c46749

!68

!67

In theory, online integration for documents is still desired. However,
during the GNOME 3.31.x / 3.32 development cycle, GNOME Documents was
removed from the set of core applications [1] due to neglect from
designers and developers. Therefore, there is no longer any
application to offer this feature.

[1] gnome-build-meta commit 3b267376306ef600
    releng commit 4fa9d6b174f97427
    gnome-build-meta!157

!66

GNOME Online Accounts still uses the old versioning scheme because the
minor and micro versions are exposed as integers in the public API due
to goa_check_version and GOA_CHECK_VERSION.

Kjartan Maraas authored Nov 30, 2020 and Administrator committed Nov 30, 2020

(cherry picked from commit e16e32b7)

NULL is a valid return value for goa_client_get_manager and isn't
accompanied by the throwing of an error. This is why it needs to be
annotated [1].

This should have been included in commit 728d2bf1, which
updated the rest of the goa_client_get_manager documentation to mention
that it can return NULL.

[1] https://wiki.gnome.org/Projects/GObjectIntrospection/Annotations

#139

Since WebKitGTK 2.4, webkit_web_extension_initialize_with_user_data is
the preferred entry point for a WebKitWebExtension. The older entry
point (ie., webkit_web_extension_initialize) isn't sufficient and isn't
expected to work anyway, and there's no need to define both entry
points.

Therefore, remove the definition of the older entry point to avoid
unexpected failures if, for some reason, WebKitGTK picks the wrong
entry point when loading the extension.

#76

When signing in a Kerberos identity, krb5_get_init_creds_password
invokes the krb5_prompter_fct callback when it wants to interact with
the user. In this case the prompter callback is on_kerberos_inquiry.

Interactions with the user can either prompt the user to provide some
further information, like a password, or they might be purely
informational. In the latter case, the prompter callback is called with
number_of_prompts set to 0. When this happens, the GoaKerberosIdentity
instance waits for the user to respond, even if the GoaIdentityInquiry
doesn't have anything in it for the user to respond to. This leads to
a deadlock.

In practice, such purely informational messages are non-critical. eg.,
it might be about notifying the user when her password is about to
expire. Moreover, the current Online Accounts user interface in
Settings doesn't have a good way to present this sort of information,
because it's only available after the user has entered the password
through the user interface.

Therefore, information-only prompts are handled by turning the
prompter callback into a NOP, which returns success without doing
anything else.

#92

This will make the subsequent commit easier to read.

#92

GNOME Music was added to the list of core applications in GNOME 3.26:
https://blogs.gnome.org/mcatanzaro/2017/08/13/gnome-3-26-core-applications/

#134

If the org.gnome.OnlineAccounts D-Bus service isn't available, then
goa_client_get_manager might return NULL.

#139

Fixes #125

Baurzhan Muftakhidinov authored Jun 25, 2020 and Administrator committed Jun 25, 2020

(cherry picked from commit 40806275)