Follow-up from "player: Synchronize Player and PlayerPlaylist repeat_mode"
The following discussion from !274 (merged) should be addressed:
-
@mschraal started a discussion: (+3 comments) This whole thing is rather convoluted anyway.
In
Window
the gsetting is made into a action, this action is then used inPlayerToolbar.ui
to get/set state.On the other hand is
PlayerPlaylist
which only listens to the setting and notifies the change toPlayer
. This notify change then is listened to byPlayerToolbar
, but it only changes the look of the button.But redoing this would -I think- actually mean writing the button + popover ourselves and then doing the action handling there and just propagating from there. Although ideally I would maybe want actions in one logical place and that is probably
Window
as they are tied to it.We do need to properly rewrite this in time, as the logic is all over the place at the moment: in different objects and UI files and actually pretty much directly tied to a button.