GitLab

Previously, PlaylistsView relied on a function called
"remove_playlist" to delete the current playlist. Now, a Gtk.Action
named "playlist_delete" is used.

This prevents an error if the new playlist title contains a quotation
mark.

Closes: #447

This prevents an error if the playlist title contains a quotation
mark.

Related: #447

This prevents a crash if a playlist cannot be created.

Related: #447

When drag'n dropping a song, a SongWidget row is created for dragging
the song to the desired place. This created song row should have the
same appearance than the original and the song number should not be
shown in non-dynamic playlists.

This is assured by matching the show_song_number value from the
original widget.

This is used by StarHandlerWidget to prevent access to protected
attributes.

Make sure that the discbox is not None before setting the
show_disc_label property.

This prevents a rare fatal error on launch.

Fixes #430

With the template port of SongViews (MR !711), SongViews._view has been
renamed to SongsView._songs_view.
The call from starhandlerwidget has not been updated to the new name,
causing Music to crash when trying to favorite a song from the songs
list.
This fix the crash by using the correct name.

Close #441

CoreModel used to have a property named active_playlist to keep track
of the playlist being played. This property has been superseded by the
active_core_object property which keeps track of the object being
played (playlist, artist, song or album). However, the delete_action
from PlaylistCreation was not updated to use active_core_object. This
results in a crash when a playlist is deleted.

This issue is fixed by replacing active_playlist with
active_core_object.

Fixes: 2aaa6e61

A previous commit fixed the style of the checkboxes in AlbumWidget by
removing the 'content-view' css style of the AlbumWidget. This indeed
fixed this issue but introduced a new one: the disc labels now have a
wrong color.

This new issue is fixed by updating the disc-label css style. The
DiscBox activatable property is also set to False to prevent a color
change on DiscBox hover.

Related: 4667eee3

(cherry picked from commit bf56b28e)

With the previous SMALL removed, there is no need to keep a XSMALL
name.

A 'songs-available' checks happens on launch to check that the music
library is not empty. If no music is available, an empty view is
displayed. This relies on Tracker being already loaded. However, if
Tracker is not yet available, the EmptyView is shown for a very short
time and then the AlbumsView is displayed once Tracker becomes
available.

This issue is fixed by adding a timeout to ensure that Tracker is
loaded before checking songs availability.

Related: #423

The empty view is the first view added to the stack. Therefore, it can
be visible by at startup before the album view starts to be
populated.

This issue is fixed by making this view hidden by default. It becomes
visible if it needs to be shown.

Related: #423

Due to a css change in Gtk 3.24.21, the selection checkboxes have
become very big because a wrong style is applied. This is fixed by
removing the "content-view" class to the AlbumWidget.
This change is also valid for previous versions of Gtk.

See:
gtk@7fd126e2

Closes: #414

Remove notifications contain two events for the same file. One event as a
file uri and the other one as a nie:InformationElement. Only the
nie:InformationElement event needs to be kept because it is saved in
the hash.

It is not used anymore. All the selection logic now relies on GObject
properties.

With the move to Tracker3 the parser no longer handles quoted arguments
to the IN operater.

Use int exclusively: 0 is equal to no connection.

Use int exclusively: 0 is equal to no timeout.

It now returns the year when the media was published (see commit
350dabc9).

The grilo tracker2 plugin maps the nie:contentCreated property (the
date of a song) to the CREATION_DATE key.
However, the CREATION_DATE key is supposed to be used to describe the
creation of a media such as an image.

In the tracker3 plugin, the nie:contentCreated property now also maps
the PUBLICATION_DATE key (CREATION_DATE is kept for backward
compatibility). Music can now use the PUBLICATION_DATE key instead of
the CREATION_DATE one.

In theory it can be None, so the type checker wants this.

It is None, it is confusing with regards to the callback arguments order
and it is in line with all the other Grilo callbacks in Music.

Art retrieval callbacks were convoluted. Do some cleanups and
simplifications.

The old method returned an empty list, which trips up the type
checker.

Use int exclusively: 0 is equal to no timeout.
Explicitly return GLib.SOURCE_REMOVE.