The source project of this merge request has been removed.
Draft: GTK4 Adaptive Bringup
Closes #255.
As the old MR !513 seems abandoned and targets the old gtk+ 3.0 version of gnome-music (and I didn't saw it existing xD) I tried to make the new gnome-music adaptive. For that I moved the Albums-, Artists-, Songs- and PlaylistsViews inside a stack in the new DiscoverView, added a Adw.ViewSwitcherBar to the DiscoverView, replaced the ViewSwitcher in the HeaderBar with ViewSwitcherTitle and added the DiscoverView to the main _stack.
My question now: Is this MR following the right general approach? (And should I fix it and make it mergeable?)
Needs to be fixed:
-
Fancier Code (It was at first a quick hack and doesn't reflect the code-quality guidelines.) -
window.py line 274 _on_key_press needs to be updated -
Fix Selection of ArtistsView and PlaylistsView -
Fix Search (wrong stack get's switched) -
ViewSwitcherBar Animation -
PlayerToolbar not adaptive (Not possible to read labels) (Needs Design: Should the cover and title be moved above the controls for readabilty on mobile? Or even show the cover?) -
Adaptive ArtistsView (using AdwFlap?) -
Adaptive PlaylistsView -
Adaptive AlbumWidget -
More Adaptive SongsView (it's fine for now, but could be more readable) -
Full Player View would be nice (needs Design, seperate Feature and doesn't needs to be part of this MR)