gnome-music issueshttps://gitlab.gnome.org/GNOME/gnome-music/-/issues2022-02-17T15:25:47Zhttps://gitlab.gnome.org/GNOME/gnome-music/-/issues/299[META] Core rework known issue list2022-02-17T15:25:47ZMarinus Schraalmschraal@gnome.org[META] Core rework known issue listThe core rework is basically a complete rewrite of the underpinnings of GNOME Music. This should make it be easier to deal with issues that have been open for years. The change is so invasive that it touches pretty much every bit of the ...The core rework is basically a complete rewrite of the underpinnings of GNOME Music. This should make it be easier to deal with issues that have been open for years. The change is so invasive that it touches pretty much every bit of the codebase and regressions are to be expected. This issue provides an overview of known issues.
The main work before being merged to master was done in !420, !455 & !454.
### General
- [x] Activating a song resets all state (played) on the current view. (!461)
- [x] print statements instead of proper logging all around (!612)
- [x] Remote album art retrieval is not working, cached art shows ok (!457)
- [ ] Keyboard navigation with new list style
- [x] Make favorites a (Grl)Tracker only thing (!482)
- [x] `AlbumCover` delays loading of art by an ever increasing timer (previous workaround for FlowBox performance limitations). (!538)
- [x] Update screenshots (#327)
- [x] Restore loading notifications (!511)
### Selections
- [ ] Selection mode is slow on large sets (on initial run). This is because all the CoreSong's get lazily created.
- [ ] Large selections still crash Music (#196)
- [x] Make selection only possible for (Grl)Tracker CoreSong's at this point (playlists are a Tracker only thing) (!482)
### `CoreGrilo`
- [ ] Source removal is not handled (mainly important online sources) (#31)
- [x] Search sources
- [ ] wrappers
- [x] Large scale additions/removals are inefficiently handled and lock up. (probably mostly done with !458)
- [ ] `CoreDisc` not updated on changes (discs stay around) (!655)
### `PlaylistsView`
#### context menu
- [x] play song
- [x] add song
- [x] remove song
#### playlist menu
- [x] play playlist
- [x] rename playlist
- [x] delete playlist
#### general and ui
- [x] select first playlist on start
- [x] drag and drop operation
- [x] `SongWidget` needs to show `artist` and `album`
- [x] update playlist button style
- [x] Play action should not be active if the playlist is empty
### `PlaylistDialog`
- [x] port to new model
- [x] fix critical warnings (!495)
- [x] new playlist creation
### `SearchView`
- [x] Does not search anything beyond Tracker at this point
- [x] Add generic search for any source that supports search
- [ ] Not sure if it updates on changes
### `SmartPlaylists`
- [x] No live update (!497)
- [x] Crash on smart playlist item removal (#309) (!494)
### `Player`
- [x] remove `get_mpris_playlist` -> use `coremodel` `playlist_sort` in `MPRIS`
- [x] fix play_plause
- [x] remove obsolete code
- [x] stop player if the model is deleted
- [x] update player playlist if the model is updated (!493)
- [ ] Shuffle needs improvement (#369)
- [x] No discovery, is it still needed for something? -> discovery restored for the moment
- [x] If the URL does not exist they player just stops and does nothing (does not skip)
- [ ] rename to avoid any ambiguity between the song position in the playlist and the song curent position white it's being played
### `ArtistsView`
- [x] select first artist on start
- [x] port to `ListBox` (needs to be fixed)
- [x] strange loading effect when an artist has lot of albums -> fixed
- [x] live updates (depends on `check_artist_change`) -> FIXME: probably does not work well yet
- [ ] improve loading looks. Currently the albums might be loaded without the actual models being available, giving an accordion effect.
- [x] weird selection-mode state (#300) (!500)
### `SearchView`
- [ ] rework searchbar drop down (#217)
- [ ] search only specific sources
- [ ] search only specific attributes in Tracker (title/artist/composer/etc)
- [x] fix up looks (#45) https://gitlab.gnome.org/Teams/Design/app-mockups/blob/master/music/music-search.png
- [x] gapless playback: song change does not match UI change
### `GrlTrackerSource`
- [x] implement `check_artist_change`
### New list style
See https://gitlab.gnome.org/Teams/Design/app-mockups/blob/master/music/music-list-style.png. Related #235.
- [x] `AlbumsWidget`
- [x] `ArtistsView`
- [x] `PlaylistsView`
- [ ] `SongsView`: to do (for performance reasons this has to wait for GTK4)
- [x] `SearchView`
### `MPRIS`
- [x] `Playlists` use the new api (!521)
### Misc - cleanup
- [x] Remove `DiscSongsFlowBox` (it is not used anymore)
- [x] Rename `SidebarRow` to `PlaylistRow`GNOME 3.34