1. 30 Mar, 2021 1 commit
  2. 28 Mar, 2021 1 commit
  3. 26 Mar, 2021 1 commit
    • Jean Felder's avatar
      window: Fix album view selection by the stack switcher on launch · 13571354
      Jean Felder authored
      The first view added to the stack is the EmptyView which is not
      visible on launch. Then, AlbumsView is added and becomes the
      visible_child by default because it is visible. However, it is not
      selected by the the stack switcher because the
      "notify::visible-changed" signal is received before the child is added
      to the stack switcher.
      
      This issue is fixed by adding a "visible-child" notification. This
      way, the stack switcher selected the AlbumView on launch.
      13571354
  4. 23 Mar, 2021 1 commit
  5. 22 Mar, 2021 6 commits
    • Jean Felder's avatar
      d40c3b9e
    • Jean Felder's avatar
      grltrackerplaylists: Fix removal of songs from a playlist · 100b95b6
      Jean Felder authored
      When a song is removed from a playlist, the song id is directly used
      to remove the song from the playlist and update it. However, the song
      in the playlist (the entry) is different from the song itself. Hence,
      the song id cannot be used directly.
      
      The issue is fixed by first retrieving the entry id and then use it to
      remove the song from the playlist.
      100b95b6
    • Jean Felder's avatar
      grltrackerplaylists: Fix add_songs docstring · 4e36a505
      Jean Felder authored and Jean Felder's avatar Jean Felder committed
      4e36a505
    • Jean Felder's avatar
      grltrackerplaylists: Do not add the same song several times · f902e2cd
      Jean Felder authored and Jean Felder's avatar Jean Felder committed
      When songs are added to a user playlist, a query is performed to
      update the playlist and display the new songs. However, this query
      inserts a new song several times if it was already part of the
      playlist because it only filters the song id.
      
      This issue is fixed by adding a limit of one to the query.
      f902e2cd
    • Jean Felder's avatar
      grltrackerplaylists: Fix update playlist query when adding songs · 49737ba3
      Jean Felder authored and Jean Felder's avatar Jean Felder committed
      When songs are added to a user playlist, a query is performed to
      update the playlist and display the new songs. However, this query
      does not work because the url parameter is not correctly selected.
      
      This commit fixes the query by adding the following elements:
      - select url in the tracker:Audio graph
      - move the filter of the song id in tracker:Audio graph selection to
        ensure that the resource is available
      - add a playlist id filter to prevent selection of the same song
        several times if it is already part of an other playlist
      
      Closes: #445
      49737ba3
    • Jean Felder's avatar
      gstplayer: Fix change to stopped state · 03b59bf1
      Jean Felder authored
      Since commit 703692e9, gstplayer state changes are asynchronous. It
      relies on listening to the "state-changed" message from the pipeline
      to update its state. However, changing the state to NULL (ie. STOPPED
      in gstplayer terminology) flushes the pipeline. Thus, the change
      message never arrives.
      This results in the playbar staying in a weird state at the end of a
      playlist because the STOPPED state change is never received.
      
      This issue is fixed by changing gstplayer state to STOPPED when this
      state is requested.
      
      Closes: #411
      03b59bf1
  6. 21 Mar, 2021 1 commit
  7. 14 Mar, 2021 2 commits
  8. 13 Mar, 2021 3 commits
  9. 24 Feb, 2021 7 commits
  10. 23 Feb, 2021 4 commits
  11. 21 Feb, 2021 1 commit
  12. 08 Jan, 2021 1 commit
  13. 03 Jan, 2021 1 commit
  14. 18 Dec, 2020 1 commit
    • Jean Felder's avatar
      playlistcontrols: Fix playlist deletion · b789d971
      Jean Felder authored
      CoreModel used to have a property named active_playlist to keep track
      of the playlist being played. This property has been superseded by the
      active_core_object property which keeps track of the object being
      played (playlist, artist, song or album). However, the delete_action
      from PlaylistCreation was not updated to use active_core_object. This
      results in a crash when a playlist is deleted.
      
      This issue is fixed by replacing active_playlist with
      active_core_object.
      
      Fixes: 2aaa6e61
      b789d971
  15. 15 Dec, 2020 1 commit
    • Jean Felder's avatar
      discbox: Fix disc label color · 3570c1aa
      Jean Felder authored and Jean Felder's avatar Jean Felder committed
      A previous commit fixed the style of the checkboxes in AlbumWidget by
      removing the 'content-view' css style of the AlbumWidget. This indeed
      fixed this issue but introduced a new one: the disc labels now have a
      wrong color.
      
      This new issue is fixed by updating the disc-label css style. The
      DiscBox activatable property is also set to False to prevent a color
      change on DiscBox hover.
      
      Related: 4667eee3
      3570c1aa
  16. 12 Dec, 2020 1 commit
  17. 04 Dec, 2020 1 commit
  18. 20 Nov, 2020 4 commits
  19. 13 Nov, 2020 2 commits
    • Jean Felder's avatar
      emptyview: Do not make it visible by default · 2edebb02
      Jean Felder authored
      The empty view is the first view added to the stack. Therefore, it can
      be visible by at startup before the album view starts to be
      populated.
      
      This issue is fixed by making this view hidden by default. It becomes
      visible if it needs to be shown.
      
      Related: #423
      2edebb02
    • Jean Felder's avatar
      albumwidget: Fix selection checkboxes style · 4667eee3
      Jean Felder authored
      Due to a css change in Gtk 3.24.21, the selection checkboxes have
      become very big because a wrong style is applied. This is fixed by
      removing the "content-view" class to the AlbumWidget.
      This change is also valid for previous versions of Gtk.
      
      See:
      gtk@7fd126e2
      
      Closes: #414
      4667eee3