- 28 Mar, 2021 1 commit
-
-
- 26 Mar, 2021 1 commit
-
-
Jean Felder authored
The first view added to the stack is the EmptyView which is not visible on launch. Then, AlbumsView is added and becomes the visible_child by default because it is visible. However, it is not selected by the the stack switcher because the "notify::visible-changed" signal is received before the child is added to the stack switcher. This issue is fixed by adding a "visible-child" notification. This way, the stack switcher selected the AlbumView on launch.
-
- 23 Mar, 2021 1 commit
-
-
- 22 Mar, 2021 6 commits
-
-
Jean Felder authored
-
Jean Felder authored
When a song is removed from a playlist, the song id is directly used to remove the song from the playlist and update it. However, the song in the playlist (the entry) is different from the song itself. Hence, the song id cannot be used directly. The issue is fixed by first retrieving the entry id and then use it to remove the song from the playlist.
-
-
When songs are added to a user playlist, a query is performed to update the playlist and display the new songs. However, this query inserts a new song several times if it was already part of the playlist because it only filters the song id. This issue is fixed by adding a limit of one to the query.
-
When songs are added to a user playlist, a query is performed to update the playlist and display the new songs. However, this query does not work because the url parameter is not correctly selected. This commit fixes the query by adding the following elements: - select url in the tracker:Audio graph - move the filter of the song id in tracker:Audio graph selection to ensure that the resource is available - add a playlist id filter to prevent selection of the same song several times if it is already part of an other playlist Closes: #445
-
Jean Felder authored
Since commit 703692e9, gstplayer state changes are asynchronous. It relies on listening to the "state-changed" message from the pipeline to update its state. However, changing the state to NULL (ie. STOPPED in gstplayer terminology) flushes the pipeline. Thus, the change message never arrives. This results in the playbar staying in a weird state at the end of a playlist because the STOPPED state change is never received. This issue is fixed by changing gstplayer state to STOPPED when this state is requested. Closes: #411
-
- 21 Mar, 2021 1 commit
-
-
Jean Felder authored
-
- 14 Mar, 2021 2 commits
-
-
Jean Felder authored
-
-
- 13 Mar, 2021 3 commits
-
-
-
Ask Hjorth Larsen authored
-
Ask Hjorth Larsen authored
-
- 24 Feb, 2021 7 commits
-
-
-
-
Previously, PlaylistsView relied on a function called "remove_playlist" to delete the current playlist. Now, a Gtk.Action named "playlist_delete" is used.
-
-
Jean Felder authored
This prevents an error if the new playlist title contains a quotation mark. Closes: #447
-
Jean Felder authored
This prevents an error if the playlist title contains a quotation mark. Related: #447
-
Jean Felder authored
This prevents a crash if a playlist cannot be created. Related: #447
-
- 23 Feb, 2021 4 commits
-
-
When drag'n dropping a song, a SongWidget row is created for dragging the song to the desired place. This created song row should have the same appearance than the original and the song number should not be shown in non-dynamic playlists. This is assured by matching the show_song_number value from the original widget.
-
Jean Felder authored
This is used by StarHandlerWidget to prevent access to protected attributes.
-
J. A. Baker authored
Make sure that the discbox is not None before setting the show_disc_label property. This prevents a rare fatal error on launch. Fixes #430
-
With the template port of SongViews (MR !711), SongViews._view has been renamed to SongsView._songs_view. The call from starhandlerwidget has not been updated to the new name, causing Music to crash when trying to favorite a song from the songs list. This fix the crash by using the correct name. Close #441
-
- 21 Feb, 2021 1 commit
-
-
- 08 Jan, 2021 1 commit
-
-
Jordi Mas authored
-
- 03 Jan, 2021 1 commit
-
-
Jordi Mas authored
-
- 18 Dec, 2020 1 commit
-
-
Jean Felder authored
CoreModel used to have a property named active_playlist to keep track of the playlist being played. This property has been superseded by the active_core_object property which keeps track of the object being played (playlist, artist, song or album). However, the delete_action from PlaylistCreation was not updated to use active_core_object. This results in a crash when a playlist is deleted. This issue is fixed by replacing active_playlist with active_core_object. Fixes: 2aaa6e61
-
- 15 Dec, 2020 1 commit
-
-
A previous commit fixed the style of the checkboxes in AlbumWidget by removing the 'content-view' css style of the AlbumWidget. This indeed fixed this issue but introduced a new one: the disc labels now have a wrong color. This new issue is fixed by updating the disc-label css style. The DiscBox activatable property is also set to False to prevent a color change on DiscBox hover. Related: 4667eee3
-
- 12 Dec, 2020 1 commit
-
-
- 04 Dec, 2020 1 commit
-
-
(cherry picked from commit bf56b28e)
-
- 20 Nov, 2020 4 commits
-
-
Jean Felder authored
With the previous SMALL removed, there is no need to keep a XSMALL name.
-
Jean Felder authored
-
Jean Felder authored
-
Jean Felder authored
A 'songs-available' checks happens on launch to check that the music library is not empty. If no music is available, an empty view is displayed. This relies on Tracker being already loaded. However, if Tracker is not yet available, the EmptyView is shown for a very short time and then the AlbumsView is displayed once Tracker becomes available. This issue is fixed by adding a timeout to ensure that Tracker is loaded before checking songs availability. Related: #423
-
- 13 Nov, 2020 2 commits
-
-
Jean Felder authored
The empty view is the first view added to the stack. Therefore, it can be visible by at startup before the album view starts to be populated. This issue is fixed by making this view hidden by default. It becomes visible if it needs to be shown. Related: #423
-
Jean Felder authored
Due to a css change in Gtk 3.24.21, the selection checkboxes have become very big because a wrong style is applied. This is fixed by removing the "content-view" class to the AlbumWidget. This change is also valid for previous versions of Gtk. See: gtk@7fd126e2 Closes: #414
-
- 12 Nov, 2020 1 commit
-
-
Jean Felder authored
Remove notifications contain two events for the same file. One event as a file uri and the other one as a nie:InformationElement. Only the nie:InformationElement event needs to be kept because it is saved in the hash.
-