Marinus Schraal authored May 08, 2018 and Marinus Schraal committed May 08, 2018

With the switch to Meson the default icon name is now org.gnome.Music.
Fixes the icon not showing in gnome-control-center.


(cherry picked from commit eeea5f41)

Georges Basile Stavracas Neto authored Mar 01, 2018 and Marinus Schraal committed Apr 08, 2018

By setting the main window's stack to not homogeneous, we won't try to
allocate all the views every time the window is allocated.

And by reducing the maximum number of albums per row, and knowing that
asymptotic complexity of the GtkFlowBox allocation is O(max²), we can
save some good hundreds of thousands of cycles too.


(cherry picked from commit cbee5094)

Cannot open search bar via Ctrl + F if a playlist renaming is active.

Cannot open search bar from a search result (album or artist).

Closes: #148

A regression was introduced by commit da347498. Selection popup items
became insensitive.

Closes: #152

Marinus Schraal authored Feb 24, 2018 and Marinus Schraal committed Feb 24, 2018

- Remove camelcase _selectionMode
- Make _selection_mode an instance variable
- Add selection_mode property
- Replace _selectionMode usage

Jean Felder authored Feb 21, 2018 and Jean Felder committed Feb 23, 2018

This should fix bluetooth headsets problems.
- first press: a Gdk.KEY_Audio event is received
- second press: handled by dbus settings daemon

Closes: #93

Jean Felder authored Feb 21, 2018 and Jean Felder committed Feb 23, 2018

Refactor media_player_keys code.
Make all the calls async.
Correctly register warnings and errors from media_keys.

Add select_none shortcut in selection mode.
Shortcuts logic should be defined in only one place to avoid confusion.

Remove unused button parameter
Use View enum
Remove useless comments

Delete all pending songs and playlists when closing Music.
Closes: #106

Handle loading and playlist removal notifications.
Add the possibility to remove multiple playlists independently.
Remove all notification code from window.py.

Remove all remaining calls to _remove_from_playlist_button
Commit d19b0e3a removed obsolete "Remove from playlist button" but
there were still remaining references all over the code.

"Remove from playlist" button is not used anymore. Song removal from a
playlist is now handled by a context menu.

Convert self._view to Gtk.TreeView
Remove dependencies to libgd

Closes #48

Subhadip Jana authored Jan 09, 2018 and Marinus Schraal committed Jan 16, 2018

Use set_accels_for_action method instead.

Use direct naming to make functionality more obvious.
show_bar -> reveal
toggle_bar -> toggle

Use an enum to clarify what view is being referred to, instead of using
numerical values.

The codebase was using mixed style (Python 2 & 3) superclass calls,
replace it with Python 3 super() calls only.

Phil Dawson authored Dec 27, 2017 and Marinus Schraal committed Dec 27, 2017

https://bugzilla.gnome.org/show_bug.cgi?id=788701

theawless authored Jan 14, 2017 and Marinus Schraal committed Dec 19, 2017

Creates the same effect as having pressed "Alt+Left" combination.
Override button_release_event to handle mouse button 8.

https://bugzilla.gnome.org/show_bug.cgi?id=771934

theawless authored Jan 14, 2017 and Marinus Schraal committed Dec 19, 2017

Shortcut navigation back behaviour was missing some conditions while ui
behaviour was good. Hence now calling the same function.

https://bugzilla.gnome.org/show_bug.cgi?id=777238

Jean Felder authored Dec 19, 2017 and Marinus Schraal committed Dec 19, 2017

https://bugzilla.gnome.org/show_bug.cgi?id=744822

Replace albumArtist and artistAlbumsWidget with album_artist
and artist_albums_widget respectively.

FlorianDarfeuille authored Dec 11, 2017 and Marinus Schraal committed Dec 15, 2017

Fixes warnings for E111, E201, E202, E203, E302, E711, E712.

https://bugzilla.gnome.org/show_bug.cgi?id=791481

Set default icon instead of just window icon, so it gets picked up by
pulseaudio as application property. Fixes the incorrect icon showing in
gnome-control-center.

https://bugzilla.gnome.org/show_bug.cgi?id=709073

See https://bugzilla.gnome.org/show_bug.cgi?id=781326

https://bugzilla.gnome.org/show_bug.cgi?id=781754

During population of the dialog's list, check if the item id is equal to
the id of the playlist that is going to be deleted. If true, then do not
display the item.

https://bugzilla.gnome.org/show_bug.cgi?id=780523

Removed close buttons from loading and remove playlist notifications,
and removed really_delete which was unnecessarily complicating
behaviour.

https://bugzilla.gnome.org/show_bug.cgi?id=777041

Fixed an oversight.

https://bugzilla.gnome.org/show_bug.cgi?id=774470

Adds empty state for the playlists dialog when no user-created playlists
are available yet, in line with the design team mockups.

https://bugzilla.gnome.org/show_bug.cgi?id=772089

When loading e.g. an artists, the notification can show and
hide very quickly, causing a very bad impression since we didn't
really spend any time loading it.

Fix that by setting a small timeout of 500ms before showing
the notification.

https://bugzilla.gnome.org/show_bug.cgi?id=776157

Turns the playlist notification into a GtkRevealer, and reorganize the
code to better publically expose it.

https://bugzilla.gnome.org/show_bug.cgi?id=776157