Marinus Schraal authored May 08, 2018 and Marinus Schraal committed May 08, 2018

With the switch to Meson the default icon name is now org.gnome.Music.
Fixes the icon not showing in gnome-control-center.


(cherry picked from commit eeea5f41)

Commit b5fdf34c was incomplete and still triggered updates. Make sure
BaseView does not reset the init state unwanted.

Runtime updates are broken in AlbumsView.
Make sure updates are disabled after initial population.

The runtime update code used a direct tracker call to check if a Grl.Media
was an audio file. Grilo provides API for this, use it instead and remove
the is_audio query.

Alexander Mikhaylenko authored Mar 30, 2018 and Marinus Schraal committed May 07, 2018

Since album widget population is async, it's not guaranteed that
the last album in the list will load last. In particular, this
can happen if the last album is small, and next to last album is
large.

Fixes #174


(cherry picked from commit 761b70410a8224d6f5d170b3ca3fdd19bca67be5)

4 views are populated on startup: Albums, Artists, Songs and
Playlists. Each populate call goes with a push_loading call to display a
loading notification popup and increment a counter. However,
push_loading call from PlaylistView never happens because it is placed
in _populate method instead of populate.
A push_loading call happens in SearchView on startup. It shouldn't be
the case as this view is not populated on startup.

The following changes solve this isssue:
Moving push_loading call from PlaylistView in the populate method.
Moving push_loading call from SearchView in the set_search_text
method.
PlaylistView does not need a specific _populate method as this is now
the same as BaseView.

Closes: #111

One only need to create it at launch time and clear it if necessary. Its
structure does not change.

Jean Felder authored Mar 29, 2018 and Marinus Schraal committed Apr 08, 2018

It prevents ellipsized songs from being improperly aligned in Artists
View.

Closes: #173


(cherry picked from commit 557555da)

Jean Felder authored Apr 04, 2018 and Marinus Schraal committed Apr 08, 2018

If the notification is visible, it means that the timeout is already
finished. In that case, source_remove does not need to be called.


(cherry picked from commit 51df37f9)

Alexander Mikhaylenko authored Mar 30, 2018 and Marinus Schraal committed Apr 08, 2018

(cherry picked from commit 1c94bd72)

Alexander Mikhaylenko authored Mar 30, 2018 and Marinus Schraal committed Apr 08, 2018

Add talk-name for g-s-d


(cherry picked from commit 9661709e)

Georges Basile Stavracas Neto authored Mar 01, 2018 and Marinus Schraal committed Apr 08, 2018

By setting the main window's stack to not homogeneous, we won't try to
allocate all the views every time the window is allocated.

And by reducing the maximum number of albums per row, and knowing that
asymptotic complexity of the GtkFlowBox allocation is O(max²), we can
save some good hundreds of thousands of cycles too.


(cherry picked from commit cbee5094)

The ui files had the 'gnome-music' gettext domain name hard coded, while
after the move to Meson we use 'org.gnome.Music' instead.

Remove the domain, so the correct gettext domain gets picked up from the
environment.

Closes: #169

It was moved to NEWS.md with the meson transition. However, the
infrastructure is not yet ready for it and the markdown part was still
unused.

* Fix links after gitlab move
* Use https everywhere

In the embedded art lookup code, there was a possibility that two
conflicting signals got sent on error.

Fix it by adding a return statement after sending the correct signal.

A logic error in the lookup flow resulted in a lookup loop if embedded
or remote art was found, but failed to retrieve. In that case a new
cache lookup was started and could start to loop through the same
failure case.

Solution in the case of embedded art are:
1. Go to the next step and try to retrieve remote art instead
2. Blacklist the media and stop the lookup

Implemented option 1 to give the user the best chance to retrieve some
art for the media.

For remote art we just add it to the blacklist.

Georges Basile Stavracas Neto authored Mar 06, 2018 and Marinus Schraal committed Mar 09, 2018

When a file fails to open, the stream variable is not assigned and we
jump to the exception handling code, which tries to close the stream
that was not even open.

This segfaults immediately, because nested errors in pygobject seem to
be broken.

Fix it by not trying to close the None stream object on error.

Install the Gd library in libdir, instead of datadir.

Closes #159

Jean Felder authored Feb 25, 2018 and Jean Felder committed Mar 04, 2018

Player keeps an internal reference to the currently visible view, wich
can be different from the currently played model. The main idea is to
isolate player model. when set_playlist method from player is called, a
simple copy is done. Therefore, when view changes, player model is not
updated. This new model needs to stay synchronized by calling add_song
or remove_song appropriately.
This is not a fix. Just a workaround before player.py rewrite.
Add an enum for player model fields.
Remove 'song-position-changed' signal from playlists as it is not
necessary anymore.

Closes: #136