1. 08 May, 2018 3 commits
  2. 07 May, 2018 4 commits
  3. 30 Apr, 2018 1 commit
    • Jean Felder's avatar
      views: Fix notifications_popup calls on startup · c9cf322a
      Jean Felder authored
      4 views are populated on startup: Albums, Artists, Songs and
      Playlists. Each populate call goes with a push_loading call to display a
      loading notification popup and increment a counter. However,
      push_loading call from PlaylistView never happens because it is placed
      in _populate method instead of populate.
      A push_loading call happens in SearchView on startup. It shouldn't be
      the case as this view is not populated on startup.
      
      The following changes solve this isssue:
      Moving push_loading call from PlaylistView in the populate method.
      Moving push_loading call from SearchView in the set_search_text
      method.
      PlaylistView does not need a specific _populate method as this is now
      the same as BaseView.
      c9cf322a
  4. 09 Apr, 2018 3 commits
  5. 08 Apr, 2018 5 commits
  6. 27 Mar, 2018 1 commit
  7. 26 Mar, 2018 1 commit
  8. 20 Mar, 2018 1 commit
  9. 17 Mar, 2018 2 commits
  10. 15 Mar, 2018 1 commit
  11. 13 Mar, 2018 1 commit
  12. 12 Mar, 2018 3 commits
  13. 11 Mar, 2018 1 commit
  14. 10 Mar, 2018 1 commit
  15. 09 Mar, 2018 4 commits
    • Marinus Schraal's avatar
      albumartcache: Do not send two signals on error · 3b59affc
      Marinus Schraal authored
      In the embedded art lookup code, there was a possibility that two
      conflicting signals got sent on error.
      
      Fix it by adding a return statement after sending the correct signal.
      3b59affc
    • Marinus Schraal's avatar
      albumartcache: Fix possible lookup loop · 076f6416
      Marinus Schraal authored
      A logic error in the lookup flow resulted in a lookup loop if embedded
      or remote art was found, but failed to retrieve. In that case a new
      cache lookup was started and could start to loop through the same
      failure case.
      
      Solution in the case of embedded art are:
      1. Go to the next step and try to retrieve remote art instead
      2. Blacklist the media and stop the lookup
      
      Implemented option 1 to give the user the best chance to retrieve some
      art for the media.
      
      For remote art we just add it to the blacklist.
      076f6416
    • Georges Basile Stavracas Neto's avatar
      albumartcache: Do not close non-existing stream on error · 2ba36e15
      Georges Basile Stavracas Neto authored and Marinus Schraal's avatar Marinus Schraal committed
      When a file fails to open, the stream variable is not assigned and we
      jump to the exception handling code, which tries to close the stream
      that was not even open.
      
      This segfaults immediately, because nested errors in pygobject seem to
      be broken.
      
      Fix it by not trying to close the None stream object on error.
      2ba36e15
    • Fabio Tomat's avatar
      Update Friulian translation · 92ccffd6
      Fabio Tomat authored and Administrator's avatar Administrator committed
      92ccffd6
  16. 08 Mar, 2018 1 commit
  17. 07 Mar, 2018 2 commits
  18. 05 Mar, 2018 3 commits
  19. 04 Mar, 2018 2 commits
    • Anders Jonsson's avatar
      Update Swedish translation · e472bd0f
      Anders Jonsson authored and Administrator's avatar Administrator committed
      e472bd0f
    • Jean Felder's avatar
      player: Use its own simplified model · c83e5ea7
      Jean Felder authored and Jean Felder's avatar Jean Felder committed
      Player keeps an internal reference to the currently visible view, wich
      can be different from the currently played model. The main idea is to
      isolate player model. when set_playlist method from player is called, a
      simple copy is done. Therefore, when view changes, player model is not
      updated. This new model needs to stay synchronized by calling add_song
      or remove_song appropriately.
      This is not a fix. Just a workaround before player.py rewrite.
      Add an enum for player model fields.
      Remove 'song-position-changed' signal from playlists as it is not
      necessary anymore.
      
      Closes: #136
      c83e5ea7