Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-maps gnome-maps
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 146
    • Issues 146
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-mapsgnome-maps
  • Merge requests
  • !53

Reuse UserLocationMarker when location updates

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged James Westman requested to merge jwestman/gnome-maps:fix-202 into master Sep 15, 2019
  • Overview 7
  • Commits 2
  • Pipelines 5
  • Changes 8

Instead of creating a new UserLocationMarker whenever a location update is received from GeoClue, create one UserLocationMarker and reuse it. This involves changes to MapMarker so that it will update its location when the underlying Place's location changes.

This prevents the marker's bubble from flickering when the location changes, and it should make it easier to implement a follow-location mode. Also fixes #202 (closed).

Edited Nov 05, 2019 by James Westman
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-202