Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-maps gnome-maps
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 142
    • Issues 142
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-mapsgnome-maps
  • Merge requests
  • !229

application: Dispose contact store on window destroy

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marcus Lundblad requested to merge wip/mlundblad/unref-contact-store into main Jun 20, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

When quitting through closing the window, the contact store is disposed in the final GJS GC sweep, which seems to cause some race condition with respect to the main loop. As a workaround to this, manually dispose the store in this callback, and set it to null. Also guard some calls involving contact store with nullish checks to avoid possible use-after-free.

Fixes #454 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: wip/mlundblad/unref-contact-store