gnome-maps merge requestshttps://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests2023-12-23T18:30:54Zhttps://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/331Draft: place: Store OSM tags and compute properties from them2023-12-23T18:30:54ZJames Westmanjames@jwestman.netDraft: place: Store OSM tags and compute properties from themSeveral changes to the way we store places.
## Changes
- Removed unused PlaceStore columns: icon, name, language
- Fix a bug where the current location place would sometimes make its way into the store
- Make our Place class derive fro...Several changes to the way we store places.
## Changes
- Removed unused PlaceStore columns: icon, name, language
- Fix a bug where the current location place would sometimes make its way into the store
- Make our Place class derive from GObject rather than GeocodeGLib.Place. We didn't use any of its functionality, and it'll be easier to make further changes this way.
- Switch place properties to camelCase. Now that they're not GObject properties we can't use camelCase and snake_case interchangably, and the rest of the codebase is mostly using camelCase.
- Store all OSM tags for a place.
## Place properties
Place properties are now mostly computed from OSM tags. Properties that are shown prominently in the UI (name, address, etc.) are loaded from the stored JSON as a fallback, but for most of them, there is no migration path. Instead, we consider places with no osmTags as stale and refetch them.
One effect of this is that we now localize a place's name on retrieval rather than on storage, so we can remove the language column of the place store.
## Compatibility
Older versions of Maps will not load the place store if a new field is present in a place's JSON, so this is not a forward compatible change.
## Next steps
Now that most of the place store columns are gone, the next step is to port to ListModel, which is just a list of objects. Type and Added will need to become Place properties.
The vector tile schema we're using (OpenMapTiles) doesn't always use the same tags as OSM, so we'll probably add a separate omtTags property. Vector tiles also don't contain OSM IDs (they could, for a ~10% size increase), so we'll probably want to do fuzzy matching instead of relying on the uniqueID property.https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/298Use new transport-related icons from icon-dev-kit2023-04-05T20:50:17ZMarcus LundbladUse new transport-related icons from icon-dev-kitThese have been replaced by new versions from icon-dev-kit.These have been replaced by new versions from icon-dev-kit.https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/278Updated module mainWindow.js2023-01-03T21:30:17ZGhost UserUpdated module mainWindow.jsChanged old copyright error from 2022 to 2023
![image](/uploads/0f6f01ec955e4b6168b993ea62b4a5f2/image.png)Changed old copyright error from 2022 to 2023
![image](/uploads/0f6f01ec955e4b6168b993ea62b4a5f2/image.png)https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/250Fix build against shumate 1.0.02022-10-08T11:32:57ZFabian BornscheinFix build against shumate 1.0.0This change fixes the build when shumate 1.0.0 is used. For Meson, 1.0.0.beta is a greater number then 1.0.0 and so it will not find the dependency of ">= 1.0.0.beta" in 1.0.0.
Fixes: https://gitlab.gnome.org/GNOME/gnome-maps/-/issues/482This change fixes the build when shumate 1.0.0 is used. For Meson, 1.0.0.beta is a greater number then 1.0.0 and so it will not find the dependency of ">= 1.0.0.beta" in 1.0.0.
Fixes: https://gitlab.gnome.org/GNOME/gnome-maps/-/issues/482https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/237mainWindow: Port about to AdwAboutWindow2022-08-26T20:25:37ZBrendan WilliammainWindow: Port about to AdwAboutWindowDepends on !235
~~This MR ports the about window to AdwAboutWindow, and switches to using `Adw.Application` over `Gtk.Application`.~~ It also bumps the dependencies for gtk4 and libadwaita as AdwAboutWindow was added in libadwaita 1.2....Depends on !235
~~This MR ports the about window to AdwAboutWindow, and switches to using `Adw.Application` over `Gtk.Application`.~~ It also bumps the dependencies for gtk4 and libadwaita as AdwAboutWindow was added in libadwaita 1.2.alpha, which requires gtk 4.6.
Apologies for any potential issues with this MR, this is my first code contribution to any GNOME application.https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/190bugfix 'There's no internet connection' when VPN enabled2022-04-06T21:33:47ZIvan Demidovbugfix 'There's no internet connection' when VPN enabledI've struggled for years to be able to use this app without disconnecting from VPN. I've just applied this line of code, built it and now everything works.I've struggled for years to be able to use this app without disconnecting from VPN. I've just applied this line of code, built it and now everything works.https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/25WIP: meson: set up dual installation2021-10-22T21:47:09ZBilal Elmoussaouibil.elmoussaoui@gmail.comWIP: meson: set up dual installationWIP to fix #116
Still not work correctly yet, I have switched the from `gnome-maps` to `@APPLICATION_ID@` in org.gnome.Maps.in. Since that, the app doesn't start for now. Still, need some time to figure it out
<pre>(org.gnome.MapsDeve...WIP to fix #116
Still not work correctly yet, I have switched the from `gnome-maps` to `@APPLICATION_ID@` in org.gnome.Maps.in. Since that, the app doesn't start for now. Still, need some time to figure it out
<pre>(org.gnome.MapsDevel:23317): Gjs-<font color="#657B83"><b>WARNING</b></font> **: <font color="#268BD2">21:28:48.986</font>: JS ERROR: ImportError: No JS module 'main' found in search path
start@resource:///org/gnome/gjs/modules/package.js:209:5
@./org.gnome.MapsDevel:2:1
</pre>https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/195Add <description> tags in appdata2021-10-14T20:33:24ZForeverAdd <description> tags in appdataCurrently, the Maps version history looks very sad- there aren't any release notes!
![Sad release notes](/uploads/3458c0a385589f71e6b88b6ed5b36682/Screenshot_from_2021-10-02_11-41-55.png)
The reason it was all missing was a single `<des...Currently, the Maps version history looks very sad- there aren't any release notes!
![Sad release notes](/uploads/3458c0a385589f71e6b88b6ed5b36682/Screenshot_from_2021-10-02_11-41-55.png)
The reason it was all missing was a single `<description>` tag. This MR adds in that tag to all the release notes that don't have it. Cheers!https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/187application: Unregister from DBus when asked to.2021-07-21T09:07:11ZLiliana Marie Priklerapplication: Unregister from DBus when asked to.There seems to be a typo, which keeps GNOME Maps from starting after having been closed once.
The error message looks somewhat like the following (taken from #382).
```
(org.gnome.Maps:21337): Gjs-WARNING **: 12:00:21.178: JS ERROR: Gio...There seems to be a typo, which keeps GNOME Maps from starting after having been closed once.
The error message looks somewhat like the following (taken from #382).
```
(org.gnome.Maps:21337): Gjs-WARNING **: 12:00:21.178: JS ERROR: Gio.IOErrorEnum: Er is al een object geëxporteerd voor de interface org.gnome.Sysprof3.Profiler op /org/gtk/Profiler
vfunc_dbus_unregister@resource:///org/gnome/Maps/js/application.js:280:15
```https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/157Add more files to po/POTFILES.in2021-03-20T16:06:37ZTomasz KłoczkoAdd more files to po/POTFILES.inLooks like many .ui files are still missing in po/POTFILES.in.
This patch adds all those files in which are strings to translate.Looks like many .ui files are still missing in po/POTFILES.in.
This patch adds all those files in which are strings to translate.https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/156Add more files to po/POTFILES.in2021-03-13T11:45:38ZTomasz KłoczkoAdd more files to po/POTFILES.inLooks like still manu .ui files are not added to po/POTFILES.in.
Thi patch adds all those files in which are strings to translate.Looks like still manu .ui files are not added to po/POTFILES.in.
Thi patch adds all those files in which are strings to translate.https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/142layersPopover: Make thumbnails use available width2021-01-28T21:17:44ZMarcus LundbladlayersPopover: Make thumbnails use available widthMake the layers thumbnails use available width to
avoid empty margins when labels are longer.
Fixes #330Make the layers thumbnails use available width to
avoid empty margins when labels are longer.
Fixes #330https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/139Update vi.po2021-01-25T07:19:00ZNghiêngUpdate vi.pohttps://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/127Update src/utils.js2020-12-13T21:46:00ZPradhi DasUpdate src/utils.jsRemoved the unnecessary parentheses from the return statement in src/utils.js according to the style guide of GNOMERemoved the unnecessary parentheses from the return statement in src/utils.js according to the style guide of GNOMEhttps://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/126Fixed URL Validity Checker2020-12-13T09:25:23ZRavi ShankarFixed URL Validity Checkermodified-file: src/utils.js and tests/utilsTest.js
The utility function to detect a valid URL does not takes into account the "//" followed by the URL scheme, so a simple string matching is required.
The tests/utilsTest.js is also modi...modified-file: src/utils.js and tests/utilsTest.js
The utility function to detect a valid URL does not takes into account the "//" followed by the URL scheme, so a simple string matching is required.
The tests/utilsTest.js is also modified to include test-case which fails with the GUri parser, but is a valid test case.
Closes [Issue #318](https://gitlab.gnome.org/GNOME/gnome-maps/-/issues/318)https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/71Changed http to https in several places2020-12-01T22:04:22ZGopa VasanthChanged http to https in several placesChanged HTTP to https in several places
HTTPS is a more secure protocol than HTTP protocol.Changed HTTP to https in several places
HTTPS is a more secure protocol than HTTP protocol.https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/23doc: Changelog modernisation as markdown2020-12-01T22:03:50ZNigel Stewartdoc: Changelog modernisation as markdownExample snippet:
![Screenshot_from_2018-12-23_15-57-19](/uploads/f6ff37064fb5168690a17d2161edc454/Screenshot_from_2018-12-23_15-57-19.png)Example snippet:
![Screenshot_from_2018-12-23_15-57-19](/uploads/f6ff37064fb5168690a17d2161edc454/Screenshot_from_2018-12-23_15-57-19.png)https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/69Add placeholder text for Signin fields2020-12-01T22:03:26ZSaad Patelsaad.gitlab@gmail.comAdd placeholder text for Signin fieldsFixes #239
Added property name=placeholder_text in email entry and password entry of class Gtk entry.
With these changes now the osm account dialog looks like ![Screenshot_from_2019-12-16_17-15-36](/uploads/aae4df500cd0736b0f96a77faba2...Fixes #239
Added property name=placeholder_text in email entry and password entry of class Gtk entry.
With these changes now the osm account dialog looks like ![Screenshot_from_2019-12-16_17-15-36](/uploads/aae4df500cd0736b0f96a77faba20c7f/Screenshot_from_2019-12-16_17-15-36.png)https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/70Add placeholders for email and password fields.2020-12-01T22:03:14ZGopa VasanthAdd placeholders for email and password fields.Added placeholder text to sign in fields in OpenStreetMap Account.
#239Added placeholder text to sign in fields in OpenStreetMap Account.
#239https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/73modified - osm-account-dialog.ui2020-12-01T22:02:58Zdevesh vijaywargiyamodified - osm-account-dialog.uiFixes: https://gitlab.gnome.org/GNOME/gnome-maps/issues/239
Added placeholder text for the SignIn fields(Email and Password)using placeholder_text property.
Previously
![pre](/uploads/fa8d46f226ebfb8a995fc24c977a80aa/pre.png)
Now
![po...Fixes: https://gitlab.gnome.org/GNOME/gnome-maps/issues/239
Added placeholder text for the SignIn fields(Email and Password)using placeholder_text property.
Previously
![pre](/uploads/fa8d46f226ebfb8a995fc24c977a80aa/pre.png)
Now
![post](/uploads/851d573648bea1471a554797c439ab1d/post.png)