Add to favorites (in popup) and show favorites (in the toolbar) currently use the same icon
A recent Twitter thread showing off improved mobile mode in GNOME Maps (it looks great, BTW!) also happened to illustrate how Maps uses the same star icon for both adding to favorites and viewing favorites.
Screenshot from the thread:
While the desktop form makes it a little more obvious, as the two are separated by distance and in different contexts, in the mobile mode, they're right above each other.
Both mobile and desktop would benefit by using different icons.
I suggested one (or more) of the following:
One of the icons could switch to something like:
- Add to favorites could have a combination +
⭐ icon - Multiple stars for the list of favorites (one big star, another one or two next to it that are smaller), kind of like
✨ - Use a
📓 and a⭐ together, similar to how Epiphany (GNOME Web) does the notebook dropdown in their toolbar.
I'd suggest either 1, 3, or 1+3. For consistency with Epiphany, option 3 by itself (and filling and coloring the icon gold when active) is probably best.
For reference, here's how Epiphany does it:
The icons are also in close proximity to each other, the star for favoriting (bookmarking) changes from empty to filled in color, and the bookmarks viewer icon is a book with a star on it (and never changes state).