Commit 359cdf57 authored by Scott Reeves's avatar Scott Reeves

libslab/app-resizer.c libslab/app-shell.c libslab/document-tile.c valgrind

	* libslab/app-resizer.c
	* libslab/app-shell.c
	* libslab/document-tile.c
	* main-menu/src/network-status-agent.c:
	valgrind work for memory leaks.
	Patch from Kjartan Maraas for compiler warnings and leak - BGO 400533
	A11y fix. Based on patch from Patrick Wade for BGO 399238

svn path=/trunk/; revision=197
parent 3c7bfa4d
2007-02-21 Scott Reeves <sreeves@novell.com>
* libslab/app-resizer.c
* libslab/app-shell.c
* libslab/document-tile.c
* main-menu/src/network-status-agent.c:
valgrind work for memory leaks.
Patch from Kjartan Maraas for compiler warnings and leak - BGO 400533
A11y fix. Based on patch from Patrick Wade for BGO 399238
2007-02-15 Scott Reeves <sreeves@novell.com>
* main-menu/src/system-tile.c
* main-menu/src/slab-window.c
......
......@@ -317,7 +317,7 @@ app_resizer_set_vadjustment_value (GtkWidget * widget, gdouble value)
gtk_adjustment_set_value (adjust, value);
}
gboolean
static gboolean
app_resizer_paint_window (GtkWidget * widget, GdkEventExpose * event, AppShellData * app_data)
{
/*
......
......@@ -85,7 +85,6 @@ static void handle_launcher_single_clicked (Tile * launcher, gpointer data);
static void handle_menu_action_performed (Tile * launcher, TileEvent * event, TileAction * action,
gpointer data);
static gint category_name_compare (gconstpointer a, gconstpointer b);
static gint category_data_compare (gconstpointer a, gconstpointer b);
static gint application_launcher_compare (gconstpointer a, gconstpointer b);
static void gmenu_tree_changed_callback (GMenuTree * tree, gpointer user_data);
gboolean regenerate_categories (AppShellData * app_data);
......@@ -381,6 +380,7 @@ create_actions_section (AppShellData * app_data, const gchar * title,
GtkWidget *vbox;
GSList *actions;
AppAction *action;
AtkObject *a11y_cat;
g_assert (app_data != NULL);
......@@ -405,6 +405,9 @@ create_actions_section (AppShellData * app_data, const gchar * title,
g_signal_connect (launcher, "tile-activated", G_CALLBACK (actions_handler),
app_data);
gtk_box_pack_start (GTK_BOX (vbox), launcher, FALSE, FALSE, 0);
a11y_cat = gtk_widget_get_accessible (GTK_WIDGET (launcher));
atk_object_set_name (a11y_cat, action->name);
}
}
......@@ -668,6 +671,7 @@ static void
create_application_category_sections (AppShellData * app_data)
{
GList *cat_list;
AtkObject *a11y_cat;
gint pos = 0;
g_assert (app_data != NULL);
......@@ -692,6 +696,8 @@ create_application_category_sections (AppShellData * app_data)
pos++;
g_signal_connect (data->group_launcher, "tile-activated",
G_CALLBACK (handle_group_clicked), app_data);
a11y_cat = gtk_widget_get_accessible (GTK_WIDGET (data->group_launcher));
atk_object_set_name (a11y_cat, data->category);
markup = g_markup_printf_escaped ("<span size=\"x-large\" weight=\"bold\">%s</span>",
data->category);
......@@ -1027,6 +1033,7 @@ generate_launchers (GMenuTreeDirectory * root_dir, AppShellData * app_data, Cate
break;
}
}
g_slist_free (contents);
}
static void
......@@ -1286,19 +1293,6 @@ category_name_compare (gconstpointer a, gconstpointer b)
return g_ascii_strcasecmp (category, data->category);
}
static gint
category_data_compare (gconstpointer a, gconstpointer b)
{
CategoryData *data1 = (CategoryData *) a;
CategoryData *data2 = (CategoryData *) b;
if (data1->category == NULL || data2->category == NULL)
{
g_assert_not_reached ();
}
return g_ascii_strcasecmp (data1->category, data2->category);
}
static void
tile_activated_cb (Tile * tile, TileEvent * event, gpointer user_data)
{
......
......@@ -163,7 +163,8 @@ document_tile_new (const gchar *in_uri, const gchar *mime_type, time_t modified)
"nameplate-tooltip", tooltip_text, "context-menu", context_menu, NULL);
g_free (uri);
g_free (tooltip_text);
if (tooltip_text)
g_free (tooltip_text);
priv = DOCUMENT_TILE_GET_PRIVATE (this);
priv->basename = g_strdup (basename);
......
......@@ -430,7 +430,8 @@ gtop_get_first_active_device_info ()
{
g_warning ("error opening socket\n");
return NULL;
info = NULL;
break;
}
info = g_object_new (NETWORK_STATUS_INFO_TYPE, NULL);
......@@ -443,7 +444,7 @@ gtop_get_first_active_device_info ()
info->essid = g_strdup (wl_cfg.essid);
info->iface = g_strdup (networks[i]);
return info;
break;
}
else
{
......@@ -451,11 +452,12 @@ gtop_get_first_active_device_info ()
info->essid = NULL;
info->iface = g_strdup (networks[i]);
return info;
break;
}
}
}
return NULL;
g_strfreev (networks);
return info;
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment