Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G gnome-keyring
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 94
    • Issues 94
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-keyring
  • Merge requests
  • !42

Fix sshfs: file systems that do not support hard links but make a copy instead.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Andreas requested to merge andibm/gnome-keyring:master into master Sep 25, 2021
  • Overview 10
  • Commits 2
  • Pipelines 2
  • Changes 1

Three cases need to be considered:

  1. The file system supports hard links created by link().
  2. The file system does not support link(). This is covered by calling copy_to_temp_file() instead.
  3. The file system does not support hard links, however it makes a copy instead when link() is called.

The third case is not covered yet: link() generates the file, but this is not noticed and in turn making a copy in copy_to_temp_file() fails, as the file already exists. The loop generates files until MAX_TRIES is reached.

The commit checks if 'result' exists after calling link() and covers the last case which is needed to support home directories on sshfs.

Corresponding issue: #84

Edited Sep 25, 2021 by Andreas
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master