Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G gnome-keyring
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 94
    • Issues 94
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-keyring
  • Issues
  • #105
Closed
Open
Issue created Mar 14, 2022 by Jos Dehaes@joskeContributor

gnome-keyring crashes on ssh-agent access on aarch64

I'm using mate desktop on aarch64 (M1 macbook air) with asahi linux. Using ssh-agent included in gnome-keyring-daemon always worked fine, and then suddenly started to fail strangely (core dump with nonsenical stack) with SIGILL. When I attached to a debug build with gdb, I was able to find the offending line in daemon/ssh-agent/gkd-ssh-agent-service.c:187

if (egg_buffer_get_byte (req, 4, NULL, &op) &&
    op <= GKD_SSH_OP_MAX && operations[op] != NULL)

This clearly needs to be < GKD_SSH_OP_MAX, it tried to access element with index 27 when it crashes. Not sure how this could ever work (the code hasn't changed in 4 years)? Maybe on most systems there is a null byte directly after the array? Replacing the <= with < fixes the crash.

Assignee
Assign to
Time tracking