Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
G
gnome-initial-setup
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 7
    • Merge Requests 7
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • gnome-initial-setup
  • Merge Requests
  • !105

Merged
Opened Sep 17, 2020 by Marco Trevisan@3v1n0🎺Developer

data: Leave to meson the duty of keeping the lists in sync

  • Overview 5
  • Commits 2
  • Pipelines 3
  • Changes 6

Don't leave to humans what machines can do, the gnome-initial-setup.session list is filled with an hard-to-maintain single-line semicolon separated list of components, that then are almost repeated in the gnome systemd session.conf. And these are meant to be kept in sync.

Meson can help us in this, so let's just keep a single list in meson and use it to generate the various formats we need.


A similar approach has been already done in gdm (gdm@cbd15652) and gnome-session (gnome-session@dd2ffb3d).

I didn't bump meson version here, but if we do we might simplify a bit the changes removing a few of join_paths and initializing the configuration data using a dict.
So, let me know if you want to do that as well.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: GNOME/gnome-initial-setup!105
Source branch: meson-build-session-data

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.