Update notes for contributors

See merge request !162

Part-of: <!162>

This is rather out of date. Rewrite it, removing outright falsehoods.

Part-of: <!162>

Part-of: <!162>

account: Set enterprise password errors as tooltip

See merge request !161

In GNOME 42 and earlier, this error message was used as the tooltip for
an error icon in the entry. Since the GTK 4 port, the password widget is
now a GtkPasswordEntry, which does not support adding an inline icon in
this way.

e495fb58 ("account: Fix criticals when validating domain in enterprise
login dialog") stopped attempting to add an icon using the GtkEntry
functions which don't work on GtkPasswordEntry, making this page
work without warnings/criticals once again, but in the process the error
message would not be shown anywhere.

Set the error message (from realmd or the server, I'm not sure!) as the
tooltip for the entire entry, so that it is at least accessible. Clear
it when clearing the error state.

Part-of: <!161>

account: Fix criticals when validating domain in enterprise login dialog

Closes #154

See merge request !160

Kalev Lember authored Sep 21, 2022 and Marge Bot committed Sep 22, 2022

The Cancel button was acting as OK and vice-versa.

Closes #154

Part-of: <!160>

Kalev Lember authored Sep 21, 2022 and Marge Bot committed Sep 22, 2022

Get rid of the red outline as soon as the user starts typing a new
password.

Part-of: <!160>

Kalev Lember authored Sep 15, 2022 and Marge Bot committed Sep 22, 2022

Fix the password and domain validation to work again and not spew
criticals after the gtk 4 port.

Part-of: <!160>

For reasons unknown, when I run this in a toolbox I don't get a tty. And
because the remote script requires input, sadness ensues.

Pass -t to ssh, which forces the allocation of a pseudoterminal.

While uploading the 43.0 release, the 'scp the tarball' stage failed.
After I fixed the problem, running 'ninja maintainer-upload-release'
again failed because the tag already existed.

If the tag already exists, check it points to the expected commit.

account: Show actions in enterprise login dialog

Closes #152

See merge request !159

The GtkDialog's own content_area vbox is plenty, no need to nest another
one within it.

Part-of: <!159>

While not strictly necessary, this is a moderate visual improvement.

Part-of: <!159>

In 13de947f ("account: Port to GTK4")
the use of GtkContainer:border-width was removed, but no alternative
margin was added. Readd a margin. This margin is a little wider but I
think looks fine, and is the same used in at least one dialog in
gnome-control-center.

Part-of: <!159>

Since 13de947f ("account: Port to GTK4")
the label on the cancel button was lost, as was the use_underline property
for the continue button.

gtk-cancel is no more, but happily the translatable string "_Cancel" is
already present elsewhere in this project.

While we are here, mark the Continue button as the suggested action.

Part-of: <!159>

Since 13de947f ("account: Port to GTK4")
this GtkBox would obliterate the default contents of the dialog, and as
a result the action widgets were not shown.

Correctly pack the dialog contents into the content area.

Fixes #152

Part-of: <!159>