Skip to content

font-view: Properly complete GTask on errors

Diego Escalante Urrelo requested to merge diegoe/gnome-font-viewer:diegoe/complete-failed-gtasks into master

The GTaskThreadFunc set on g_task_run_in_thread for a task has to "complete" the task with a g_task_return_() function, otherwise you can't g_task_propagate_() on the GAsyncReadyCallback set on g_task_new().

This was visible as a GLib-GIO-CRITICAL: g_task_propagate_pointer: assertion 'task->result_set' failed

Which was triggered when bluntly returning from the function when a font files had no thumbnail and consequently was reporting G_FILE_ATTRIBUTE_THUMBNAILING_FAILED.

Merge request reports